Bug 948771
| Summary: | modifyrepo does not accept the same command-line options as createrepo | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Oulevey <thomas.oulevey> | ||||||||
| Component: | createrepo | Assignee: | Packaging Maintenance Team <packaging-team-maint> | ||||||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | james.antill, lmacken, packaging-team-maint, thomas.oulevey, zpavlas | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | |||||||||||
| : | 952602 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2013-04-05 13:32:50 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 952602 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 731897 [details]
createrepo-modifyrepo-sha-simplemd_v2.diff
First patch had an error.
Created attachment 731898 [details]
createrepo-modifyrepo-sha-simplemd_v3.diff
Thanks, somewhat modifed and merged. The --simple-md-filenames and --unique-md-filenames options are complementary, we should support both. Also updated --help, to show --unique is the default. There is an issue on line 189 :
- parser.add_option("--simple-md-filenames", dest="unique_md_filenames",
+ parser.add_option("--simple-md-filenames", dest="simple_md_filenames",
Yeah, that's intended :) Both options share the same destination variable, but there's a different action- store_true vs store_false. I find this easier than handling two independent options later on. Sorry, me not reading the full line :) Thanks! works great. I asked my TAM for a backport on el6 packages. |
Created attachment 731888 [details] patch Description of problem: createrepo-0.9.9-17.el6.noarch modifyrepo does not accept the same option as createrepo. We are especially interested in --simple-md-filenames --checksum Version-Release number of selected component (if applicable): 0.9.9-17.el6 but My patch is against GIT HEAD. How reproducible: Option are not available. Steps to Reproduce: 1.modifyrepo --simple-md-filenames --checksum sha Actual results: Option not available. Expected results: Option available.