Bug 948771 - modifyrepo does not accept the same command-line options as createrepo
Summary: modifyrepo does not accept the same command-line options as createrepo
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: createrepo
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Packaging Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 952602
TreeView+ depends on / blocked
 
Reported: 2013-04-05 11:45 UTC by Thomas Oulevey
Modified: 2013-04-16 09:35 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
: 952602 (view as bug list)
Environment:
Last Closed: 2013-04-05 13:32:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch (2.72 KB, application/octet-stream)
2013-04-05 11:45 UTC, Thomas Oulevey
no flags Details
createrepo-modifyrepo-sha-simplemd_v2.diff (2.76 KB, application/octet-stream)
2013-04-05 12:37 UTC, Thomas Oulevey
no flags Details
createrepo-modifyrepo-sha-simplemd_v3.diff (3.02 KB, application/octet-stream)
2013-04-05 12:42 UTC, Thomas Oulevey
no flags Details

Description Thomas Oulevey 2013-04-05 11:45:48 UTC
Created attachment 731888 [details]
patch

Description of problem:

createrepo-0.9.9-17.el6.noarch 

modifyrepo does not accept the same option as createrepo.
We are especially interested in 
--simple-md-filenames
--checksum

Version-Release number of selected component (if applicable):

0.9.9-17.el6 
but
My patch is against GIT HEAD.

How reproducible:

Option are not available.

Steps to Reproduce:
1.modifyrepo --simple-md-filenames --checksum sha

Actual results:

Option not available.

Expected results:

Option available.

Comment 1 Thomas Oulevey 2013-04-05 12:37:45 UTC
Created attachment 731897 [details]
createrepo-modifyrepo-sha-simplemd_v2.diff

First patch had an error.

Comment 2 Thomas Oulevey 2013-04-05 12:42:52 UTC
Created attachment 731898 [details]
createrepo-modifyrepo-sha-simplemd_v3.diff

Comment 3 Zdeněk Pavlas 2013-04-05 13:32:50 UTC
Thanks, somewhat modifed and merged.  The --simple-md-filenames and --unique-md-filenames options are complementary, we should support both.  Also updated --help, to show --unique is the default.

Comment 4 Thomas Oulevey 2013-04-05 13:58:33 UTC
There is an issue on line 189 :
-    parser.add_option("--simple-md-filenames", dest="unique_md_filenames",
+    parser.add_option("--simple-md-filenames", dest="simple_md_filenames",

Comment 5 Zdeněk Pavlas 2013-04-05 14:05:22 UTC
Yeah, that's intended :)  Both options share the same destination variable, but there's a different action- store_true vs store_false.  I find this easier than handling two independent options later on.

Comment 6 Thomas Oulevey 2013-04-05 14:11:44 UTC
Sorry, me not reading the full line :)
Thanks! works great.

I asked my TAM for a backport on el6 packages.


Note You need to log in before you can comment on or make changes to this bug.