Bug 949371

For 0.93.3-1

* License
  - Please check below:
    - README.rst says this is under LGPLv3.
    - Also starcluster/templates/web/js/jquery.js seems
      MIT or GPLv2.

* rpmlint issue
  - Please fix below:
------------------------------------
StarCluster.noarch: W: doc-file-dependency /usr/share/doc/StarCluster-0.93.3/docs/epydoc/build.sh /bin/bash
------------------------------------

* Runtime dependency
  - It seems that more "Requires" is needed:
------------------------------------
[tasaka1@localhost ~]$ starcluster help
Traceback (most recent call last):
  File "/usr/bin/starcluster", line 2, in <module>
    from starcluster import cli
  File "/usr/lib/python2.7/site-packages/starcluster/cli.py", line 19, in <module>
    from starcluster import commands
  File "/usr/lib/python2.7/site-packages/starcluster/commands/__init__.py", line 1, in <module>
    from start import CmdStart
  File "/usr/lib/python2.7/site-packages/starcluster/commands/start.py", line 5, in <module>
    import optcomplete
ImportError: No module named optcomplete
------------------------------------

* Suggestion
  * Redundant description
    - "released under the LGPL license" in %description
      is not needed because such license information
      appears in License tag.

By the way I appreciate it if you would review one of my review requests (bug 958150 )

http://www.cora.nwra.com/~orion/fedora/StarCluster-0.93.3-2.fc18.src.rpm

* Thu May 2 2013 Orion Poplawski <orion.com> 0.93.3-2
- Fix up requires
- Build docs, separate package

I've sent a message to upstream and to fedora legal to help clarify the licensing.

For -2:

* Duplicate files
  - Would you explain why you make COPYING and so on included in
    both main package and -doc subpackage, and make -doc subpackage
    _not_ depending on main package?

    I don't see the situation where user just want to install -doc
    subpackage only and duplicating COPYING and so on does not seem
    to make much sense.

* As I said in bug 949311 , it may be preferable to remove egg-info
  files at %prep to ensure that egg-info files are actually rebuilt.

! And now I am waiting for license clarification.

http://www.cora.nwra.com/~orion/fedora/StarCluster-0.93.3-3.fc18.src.rpm

* Fri May 2 2013 Orion Poplawski <orion.com> 0.93.3-3
- Make doc depend on main package
- Remove shipped egg-info

And we wait for license clarification...

Okay, basically okay. I will also wait for license clarification.

I didn't see Orion's email, but a quick look over this package and I see the jquery stuff (MIT or GPLv2) and (MIT or BSD or GPLv2), most of the StarCluster stuff (LGPLv3), except for starcluster/sshutils/scp.py (LGPLv2+) and starcluster/progressbar.py (LGPLv2+), lots of the .css files (BSD), pylons.css_t (BSD), docs/sphinx/_themes/pylons/static/Neuton-webfont.svg (ASL 2.0), and utils/gitlog2changelog.py (GPLv2+).

However, that last one isn't packaged in the binary RPM. The rest are.

Main package should be:

# Core of StarCluster is LGPLv3
# sshutils/scp.py and progressbar.py are LGPLv2+
# Jquery is both (MIT or BSD or GPLv2) and (MIT or GPLv2)
License: LGPLv3 and LGPLv2+ and (MIT or BSD or GPLv2) and (MIT or GPLv2)

-doc subpackage should be:
# Neuton-webfont is ASL 2.0
# Jquery is both (MIT or BSD or GPLv2) and (MIT or GPLv2)
# Docs seem to be under same license as core module (LGPLv3)
License: LGPLv3 and BSD and ASL 2.0 and (MIT or BSD or GPLv2) and (MIT or GPLv2)

Lifting FE-Legal.

Add another comment for the -doc subpackage:

# *.css files are BSD

Thanks spot!

http://www.cora.nwra.com/~orion/fedora/StarCluster-0.93.3-4.fc18.src.rpm

* Mon May 6 2013 Orion Poplawski <orion.com> 0.93.3-4
- Final license

Two more issues:

* Cleaning up %buildroot at the beginning of %install is not needed.
* From rpmlint:
  StarCluster-doc.noarch: W: hidden-file-or-dir 
  /usr/share/doc/StarCluster-doc-0.93.3/html/.buildinfo
  Perhaps this file is not needed.

http://www.cora.nwra.com/~orion/fedora/StarCluster-0.93.3-5.fc18.src.rpm

* Mon May 6 2013 Orion Poplawski <orion.com> 0.93.3-5
- Drop buildroot cleanup
- Remove empty .buildinfo file

Okay.

------------------------------------------------------
  This package (StarCluster) is APPROVED by mtasaka
------------------------------------------------------

And thank you for license clarification, spot.

New Package SCM Request
=======================
Package Name: StarCluster
Short Description: Tool for managing computing clusters hosted on Amazon's EC2
Owners: orion
Branches: f18 f19 el6
InitialCC:

Git done (by process-git-requests).

Checked in and built.  Thanks all.

Ah.... sorry. Dependency on -doc subpackage should be:
Requires:       %{name} = %{version}-%{release}
not
Requires:       %{name}-%{version}-%{release}

Please fix this, thank you.

Thanks, fixed.