Bug 949371 - Review Request: StarCluster - Tool for managing computing clusters hosted on Amazon's EC2
Summary: Review Request: StarCluster - Tool for managing computing clusters hosted on ...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
Depends On: 949214 949302 949311
TreeView+ depends on / blocked
Reported: 2013-04-08 02:21 UTC by Orion Poplawski
Modified: 2013-05-08 14:33 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-05-07 20:25:06 UTC
Type: ---
mtasaka: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Orion Poplawski 2013-04-08 02:21:02 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/StarCluster.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/StarCluster-0.93.3-1.fc18.src.rpm
StarCluster is an open source cluster-computing toolkit for Amazon’s Elastic
Compute Cloud (EC2) released under the LGPL license.

StarCluster has been designed to automate and simplify the process of
building, configuring, and managing clusters of virtual machines on Amazon’s
EC2 cloud. StarCluster allows anyone to easily create a cluster computing
environment in the cloud suited for distributed and parallel computing
applications and systems. 

Fedora Account System Username: orion

Comment 1 Mamoru TASAKA 2013-05-02 15:49:43 UTC
For 0.93.3-1

* License
  - Please check below:
    - README.rst says this is under LGPLv3.
    - Also starcluster/templates/web/js/jquery.js seems
      MIT or GPLv2.

* rpmlint issue
  - Please fix below:
StarCluster.noarch: W: doc-file-dependency /usr/share/doc/StarCluster-0.93.3/docs/epydoc/build.sh /bin/bash

* Runtime dependency
  - It seems that more "Requires" is needed:
[tasaka1@localhost ~]$ starcluster help
Traceback (most recent call last):
  File "/usr/bin/starcluster", line 2, in <module>
    from starcluster import cli
  File "/usr/lib/python2.7/site-packages/starcluster/cli.py", line 19, in <module>
    from starcluster import commands
  File "/usr/lib/python2.7/site-packages/starcluster/commands/__init__.py", line 1, in <module>
    from start import CmdStart
  File "/usr/lib/python2.7/site-packages/starcluster/commands/start.py", line 5, in <module>
    import optcomplete
ImportError: No module named optcomplete

* Suggestion
  * Redundant description
    - "released under the LGPL license" in %description
      is not needed because such license information
      appears in License tag.

Comment 2 Mamoru TASAKA 2013-05-02 15:50:51 UTC
By the way I appreciate it if you would review one of my review requests (bug 958150 )

Comment 3 Orion Poplawski 2013-05-03 04:20:44 UTC

* Thu May 2 2013 Orion Poplawski <orion@cora.nwra.com> 0.93.3-2
- Fix up requires
- Build docs, separate package

I've sent a message to upstream and to fedora legal to help clarify the licensing.

Comment 4 Mamoru TASAKA 2013-05-03 15:57:18 UTC
For -2:

* Duplicate files
  - Would you explain why you make COPYING and so on included in
    both main package and -doc subpackage, and make -doc subpackage
    _not_ depending on main package?

    I don't see the situation where user just want to install -doc
    subpackage only and duplicating COPYING and so on does not seem
    to make much sense.

* As I said in bug 949311 , it may be preferable to remove egg-info
  files at %prep to ensure that egg-info files are actually rebuilt.

! And now I am waiting for license clarification.

Comment 5 Orion Poplawski 2013-05-03 22:42:09 UTC

* Fri May 2 2013 Orion Poplawski <orion@cora.nwra.com> 0.93.3-3
- Make doc depend on main package
- Remove shipped egg-info

And we wait for license clarification...

Comment 6 Mamoru TASAKA 2013-05-04 06:47:33 UTC
Okay, basically okay. I will also wait for license clarification.

Comment 7 Tom "spot" Callaway 2013-05-07 01:38:38 UTC
I didn't see Orion's email, but a quick look over this package and I see the jquery stuff (MIT or GPLv2) and (MIT or BSD or GPLv2), most of the StarCluster stuff (LGPLv3), except for starcluster/sshutils/scp.py (LGPLv2+) and starcluster/progressbar.py (LGPLv2+), lots of the .css files (BSD), pylons.css_t (BSD), docs/sphinx/_themes/pylons/static/Neuton-webfont.svg (ASL 2.0), and utils/gitlog2changelog.py (GPLv2+).

However, that last one isn't packaged in the binary RPM. The rest are.

Main package should be:

# Core of StarCluster is LGPLv3
# sshutils/scp.py and progressbar.py are LGPLv2+
# Jquery is both (MIT or BSD or GPLv2) and (MIT or GPLv2)
License: LGPLv3 and LGPLv2+ and (MIT or BSD or GPLv2) and (MIT or GPLv2)

-doc subpackage should be:
# Neuton-webfont is ASL 2.0
# Jquery is both (MIT or BSD or GPLv2) and (MIT or GPLv2)
# Docs seem to be under same license as core module (LGPLv3)
License: LGPLv3 and BSD and ASL 2.0 and (MIT or BSD or GPLv2) and (MIT or GPLv2)

Lifting FE-Legal.

Comment 8 Tom "spot" Callaway 2013-05-07 01:39:26 UTC
Add another comment for the -doc subpackage:

# *.css files are BSD

Comment 9 Orion Poplawski 2013-05-07 02:27:35 UTC
Thanks spot!


* Mon May 6 2013 Orion Poplawski <orion@cora.nwra.com> 0.93.3-4
- Final license

Comment 10 Mamoru TASAKA 2013-05-07 02:50:25 UTC
Two more issues:

* Cleaning up %buildroot at the beginning of %install is not needed.
* From rpmlint:
  StarCluster-doc.noarch: W: hidden-file-or-dir 
  Perhaps this file is not needed.

Comment 11 Orion Poplawski 2013-05-07 03:11:59 UTC

* Mon May 6 2013 Orion Poplawski <orion@cora.nwra.com> 0.93.3-5
- Drop buildroot cleanup
- Remove empty .buildinfo file

Comment 12 Mamoru TASAKA 2013-05-07 03:23:38 UTC

  This package (StarCluster) is APPROVED by mtasaka

And thank you for license clarification, spot.

Comment 13 Orion Poplawski 2013-05-07 18:02:42 UTC
New Package SCM Request
Package Name: StarCluster
Short Description: Tool for managing computing clusters hosted on Amazon's EC2
Owners: orion
Branches: f18 f19 el6

Comment 14 Gwyn Ciesla 2013-05-07 18:49:09 UTC
Git done (by process-git-requests).

Comment 15 Orion Poplawski 2013-05-07 20:25:06 UTC
Checked in and built.  Thanks all.

Comment 16 Mamoru TASAKA 2013-05-08 12:33:23 UTC
Ah.... sorry. Dependency on -doc subpackage should be:
Requires:       %{name} = %{version}-%{release}
Requires:       %{name}-%{version}-%{release}

Please fix this, thank you.

Comment 17 Orion Poplawski 2013-05-08 14:33:04 UTC
Thanks, fixed.

Note You need to log in before you can comment on or make changes to this bug.