Bug 949457

Summary: Review Request: nodejs-hoek - General purpose Node.js utilities
Product: [Fedora] Fedora Reporter: T.C. Hollingsworth <tchollingsworth>
Component: Package ReviewAssignee: Tom Hughes <tom>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, tom
Target Milestone: ---Flags: tom: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-25 13:57:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 948669, 949474    

Description T.C. Hollingsworth 2013-04-08 08:39:14 UTC
Spec: http://patches.fedorapeople.org/npm/nodejs-hoek.spec
SRPM: http://patches.fedorapeople.org/npm/nodejs-hoek-0.8.1-1.fc18.src.rpm
Description:
This package contains some general purpose Node.js utilities, including
utilities for working with objects, timers, binary encoding/decoding, escaping
characters, errors, and loading files.

rpmlint (all false positive):
nodejs-hoek.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-hoek.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-hoek.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-hoek.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-hoek.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Comment 1 Tom Hughes 2013-04-08 19:14:35 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
No issues. Package approved.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 61440 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: Buildroot is not present
     Note: Buildroot: present but not needed
[-]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-hoek-0.8.1-1.fc20.noarch.rpm
nodejs-hoek.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-hoek.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-hoek.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint nodejs-hoek
nodejs-hoek.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-hoek.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-hoek.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
nodejs-hoek (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-hoek:
    nodejs-hoek
    npm(hoek)



MD5-sum check
-------------
http://registry.npmjs.org/hoek/-/hoek-0.8.1.tgz :
  CHECKSUM(SHA256) this package     : dc16d4d44f6a733c9ec1c26dca55826fff4e596ad390584f87d215989100103d
  CHECKSUM(SHA256) upstream package : dc16d4d44f6a733c9ec1c26dca55826fff4e596ad390584f87d215989100103d


Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: compton-rawhide-x86_64
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 949457

Comment 2 T.C. Hollingsworth 2013-04-09 09:06:53 UTC
New Package SCM Request
=======================
Package Name: nodejs-hoek
Short Description: General purpose Node.js utilities
Owners: patches
Branches: f18 f19 el6
InitialCC:

Comment 3 Gwyn Ciesla 2013-04-09 12:06:35 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-04-11 05:50:01 UTC
nodejs-json-stringify-safe-4.0.0-2.fc19, nodejs-aws-sign-0.2.0-1.fc19, nodejs-oauth-sign-0.2.0-1.fc19, nodejs-tunnel-agent-0.2.0-1.fc19, nodejs-tobi-cookie-0.2.0-1.fc19, nodejs-npm-registry-client-0.2.20-1.fc19, nodejs-tar-0.1.17-1.fc19, nodejs-lru-cache-2.3.0-1.fc19, node-gyp-0.9.5-1.fc19, npm-1.2.17-1.fc19, nodejs-forever-agent-0.2.0-1.fc19, nodejs-cryptiles-0.2.0-1.fc19, nodejs-hoek-0.8.1-1.fc19, nodejs-sntp-0.2.1-1.fc19, nodejs-hawk-0.12.1-1.fc19, nodejs-request-2.16.6-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/FEDORA-2013-4914/nodejs-tobi-cookie-0.2.0-1.fc19,nodejs-npm-registry-client-0.2.20-1.fc19,nodejs-tar-0.1.17-1.fc19,nodejs-lru-cache-2.3.0-1.fc19,node-gyp-0.9.5-1.fc19,npm-1.2.17-1.fc19,nodejs-json-stringify-safe-4.0.0-2.fc19,nodejs-aws-sign-0.2.0-1.fc19,nodejs-oauth-sign-0.2.0-1.fc19,nodejs-tunnel-agent-0.2.0-1.fc19,nodejs-forever-agent-0.2.0-1.fc19,nodejs-cryptiles-0.2.0-1.fc19,nodejs-hoek-0.8.1-1.fc19,nodejs-sntp-0.2.1-1.fc19,nodejs-hawk-0.12.1-1.fc19,nodejs-request-2.16.6-2.fc19

Comment 5 Fedora Update System 2013-04-11 06:09:37 UTC
nodejs-oauth-sign-0.2.0-1.fc18, nodejs-tunnel-agent-0.2.0-1.fc18, nodejs-json-stringify-safe-4.0.0-2.fc18, nodejs-aws-sign-0.2.0-1.fc18, nodejs-tobi-cookie-0.2.0-1.fc18, nodejs-npm-registry-client-0.2.20-1.fc18, nodejs-tar-0.1.17-1.fc18, nodejs-lru-cache-2.3.0-1.fc18, node-gyp-0.9.5-1.fc18, npm-1.2.17-1.fc18, nodejs-forever-agent-0.2.0-1.fc18, nodejs-cryptiles-0.2.0-1.fc18, nodejs-hoek-0.8.1-1.fc18, nodejs-sntp-0.2.1-1.fc18, nodejs-hawk-0.12.1-1.fc18, nodejs-request-2.16.6-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/FEDORA-2013-5154/nodejs-tobi-cookie-0.2.0-1.fc18,nodejs-npm-registry-client-0.2.20-1.fc18,nodejs-tar-0.1.17-1.fc18,nodejs-lru-cache-2.3.0-1.fc18,node-gyp-0.9.5-1.fc18,npm-1.2.17-1.fc18,nodejs-json-stringify-safe-4.0.0-2.fc18,nodejs-aws-sign-0.2.0-1.fc18,nodejs-oauth-sign-0.2.0-1.fc18,nodejs-tunnel-agent-0.2.0-1.fc18,nodejs-forever-agent-0.2.0-1.fc18,nodejs-cryptiles-0.2.0-1.fc18,nodejs-hoek-0.8.1-1.fc18,nodejs-sntp-0.2.1-1.fc18,nodejs-hawk-0.12.1-1.fc18,nodejs-request-2.16.6-2.fc18

Comment 6 Fedora Update System 2013-04-11 16:35:22 UTC
Package nodejs-json-stringify-safe-4.0.0-2.fc19, nodejs-aws-sign-0.2.0-1.fc19, nodejs-oauth-sign-0.2.0-1.fc19, nodejs-tunnel-agent-0.2.0-1.fc19, nodejs-tobi-cookie-0.2.0-1.fc19, nodejs-npm-registry-client-0.2.20-1.fc19, nodejs-tar-0.1.17-1.fc19, nodejs-lru-cache-2.3.0-1.fc19, node-gyp-0.9.5-1.fc19, npm-1.2.17-1.fc19, nodejs-forever-agent-0.2.0-1.fc19, nodejs-cryptiles-0.2.0-1.fc19, nodejs-hoek-0.8.1-1.fc19, nodejs-sntp-0.2.1-1.fc19, nodejs-hawk-0.12.1-1.fc19, nodejs-request-2.16.6-2.fc19, nodejs-boom-0.4.0-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nodejs-json-stringify-safe-4.0.0-2.fc19 nodejs-aws-sign-0.2.0-1.fc19 nodejs-oauth-sign-0.2.0-1.fc19 nodejs-tunnel-agent-0.2.0-1.fc19 nodejs-tobi-cookie-0.2.0-1.fc19 nodejs-npm-registry-client-0.2.20-1.fc19 nodejs-tar-0.1.17-1.fc19 nodejs-lru-cache-2.3.0-1.fc19 node-gyp-0.9.5-1.fc19 npm-1.2.17-1.fc19 nodejs-forever-agent-0.2.0-1.fc19 nodejs-cryptiles-0.2.0-1.fc19 nodejs-hoek-0.8.1-1.fc19 nodejs-sntp-0.2.1-1.fc19 nodejs-hawk-0.12.1-1.fc19 nodejs-request-2.16.6-2.fc19 nodejs-boom-0.4.0-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-4914/nodejs-tobi-cookie-0.2.0-1.fc19,nodejs-npm-registry-client-0.2.20-1.fc19,nodejs-tar-0.1.17-1.fc19,nodejs-lru-cache-2.3.0-1.fc19,node-gyp-0.9.5-1.fc19,npm-1.2.17-1.fc19,nodejs-json-stringify-safe-4.0.0-2.fc19,nodejs-aws-sign-0.2.0-1.fc19,nodejs-oauth-sign-0.2.0-1.fc19,nodejs-tunnel-agent-0.2.0-1.fc19,nodejs-forever-agent-0.2.0-1.fc19,nodejs-cryptiles-0.2.0-1.fc19,nodejs-hoek-0.8.1-1.fc19,nodejs-sntp-0.2.1-1.fc19,nodejs-hawk-0.12.1-1.fc19,nodejs-request-2.16.6-2.fc19,nodejs-boom-0.4.0-1.fc19
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2013-04-25 13:57:24 UTC
nodejs-json-stringify-safe-4.0.0-2.fc19, nodejs-aws-sign-0.2.0-1.fc19, nodejs-oauth-sign-0.2.0-1.fc19, nodejs-tunnel-agent-0.2.0-1.fc19, npm-1.2.17-5.fc19, nodejs-tobi-cookie-0.2.0-1.fc19, nodejs-npm-registry-client-0.2.20-1.fc19, nodejs-tar-0.1.17-1.fc19, nodejs-lru-cache-2.3.0-1.fc19, node-gyp-0.9.5-1.fc19, nodejs-forever-agent-0.2.0-1.fc19, nodejs-cryptiles-0.2.0-1.fc19, nodejs-hoek-0.8.1-1.fc19, nodejs-sntp-0.2.1-1.fc19, nodejs-hawk-0.12.1-1.fc19, nodejs-request-2.16.6-2.fc19, nodejs-boom-0.4.0-1.fc19, nodejs-read-package-json-0.3.0-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.