Bug 949966
| Summary: | libraries.sh: internal representation of library name should be hashed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dalibor Pospíšil <dapospis> | ||||||||
| Component: | beakerlib | Assignee: | Petr Muller <pmuller> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | ohudlick, pmuller, psplicha | ||||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | beakerlib-1.7-1.fc19 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | |||||||||||
| : | 950470 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2013-05-22 03:14:54 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dalibor Pospíšil
2013-04-09 11:40:50 UTC
Created attachment 733209 [details]
Test for handling weird characters in library/component names
I made a test showing the failure to process libraries with some [^a-zA-Z0-9_] characters
Created attachment 733210 [details]
Make rlImport fail when it should
Also, I have seen that the failures invoked by the test are not really propagated in rlImport: it happily returned RC 0 after them.
This patch fixes that.
The actual processing of the libraries like component/Library/dashed-lib or libreoffice.org/Library/foo still needs to be fixed.
Created attachment 733229 [details]
internal-library-names-collide-with-bash-syntax
This patch converts the library name into the hex string so there should not be any collision with bash syntax.
Applied. My tests now all pass, thanks. 7beb83c643cefa588292b24dbf333da641be418a beakerlib-1.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/beakerlib-1.7-1.fc19 Package beakerlib-1.7-1.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing beakerlib-1.7-1.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-7067/beakerlib-1.7-1.fc19 then log in and leave karma (feedback). beakerlib-1.7-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |