Bug 949966 - libraries.sh: internal representation of library name should be hashed
Summary: libraries.sh: internal representation of library name should be hashed
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: beakerlib
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Muller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-09 11:40 UTC by Dalibor Pospíšil
Modified: 2016-09-20 02:09 UTC (History)
3 users (show)

Fixed In Version: beakerlib-1.7-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 950470 (view as bug list)
Environment:
Last Closed: 2013-05-22 03:14:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Test for handling weird characters in library/component names (2.01 KB, patch)
2013-04-09 13:02 UTC, Petr Muller
no flags Details | Diff
Make rlImport fail when it should (1.41 KB, patch)
2013-04-09 13:05 UTC, Petr Muller
no flags Details | Diff
internal-library-names-collide-with-bash-syntax (2.12 KB, patch)
2013-04-09 13:36 UTC, Dalibor Pospíšil
no flags Details | Diff

Description Dalibor Pospíšil 2013-04-09 11:40:50 UTC
Internal representation of library name should be hashed. Since there is possibility to cause bash variable name conflicts and syntax mess.
Particullary LOCATIONS_varname and IMPORTS_varname can cause some problems while evaluating.

Comment 1 Petr Muller 2013-04-09 13:02:42 UTC
Created attachment 733209 [details]
Test for handling weird characters in library/component names

I made a test showing the failure to process libraries with some [^a-zA-Z0-9_] characters

Comment 2 Petr Muller 2013-04-09 13:05:09 UTC
Created attachment 733210 [details]
Make rlImport fail when it should

Also, I have seen that the failures invoked by the test are not really propagated in rlImport: it happily returned RC 0 after them.

This patch fixes that.

The actual processing of the libraries like component/Library/dashed-lib or libreoffice.org/Library/foo still needs to be fixed.

Comment 3 Dalibor Pospíšil 2013-04-09 13:36:12 UTC
Created attachment 733229 [details]
internal-library-names-collide-with-bash-syntax

This patch converts the library name into the hex string so there should not be any collision with bash syntax.

Comment 4 Petr Muller 2013-04-09 13:52:39 UTC
Applied. My tests now all pass, thanks.

Comment 5 Petr Muller 2013-04-10 09:38:54 UTC
7beb83c643cefa588292b24dbf333da641be418a

Comment 6 Fedora Update System 2013-04-30 15:10:49 UTC
beakerlib-1.7-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/beakerlib-1.7-1.fc19

Comment 7 Fedora Update System 2013-04-30 20:04:32 UTC
Package beakerlib-1.7-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.7-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-7067/beakerlib-1.7-1.fc19
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-05-22 03:14:54 UTC
beakerlib-1.7-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.