Bug 950283

Summary: NetworkManager-vpnc spec file
Product: [Fedora] Fedora Reporter: Dan Fruehauf <malkodan>
Component: NetworkManager-vpncAssignee: Dan Williams <dcbw>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dcbw, jklimes
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-vpnc-0.9.8.2-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-26 00:27:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 949132    
Bug Blocks:    
Attachments:
Description Flags
Patch to fix spec file
none
Patch to fix spec file none

Description Dan Fruehauf 2013-04-10 02:12:45 UTC
Created attachment 733442 [details]
Patch to fix spec file

Description of problem:
NetworkManager-vpnc spec file does not conform to many Fedora Packaging guidelines

Version-Release number of selected component (if applicable):


How reproducible:
Look at spec file

Steps to Reproduce:
1. Includes for instance '%define' instead of '%global' and more
  
Actual results:
I'm providing a patch which brings NetworkManager-vpnc.spec to a better state and also splits it into NetworkManager-vpnc and NetworkManager-vpnc-gnome

Expected results:


Additional info:
I've gone through the process of changing NetworkManager-ssh.spec (based on NetworkManager-openvpn.spec) to conform with Fedora packaging standards and decided it'll be a good idea to implement these changes for the rest of the NetworkManager-* VPN plugins out there.

Comment 1 Dan Fruehauf 2013-04-11 12:34:49 UTC
Created attachment 734157 [details]
Patch to fix spec file

Comment 2 Dan Fruehauf 2013-04-11 12:36:48 UTC
Note about patch:
Contains a deliberate error (TODO) and needs to be replaced with latest known version, because of the package split. As Dan (Williams) mentioned, it is mandatory for updates to work correctly.

Comment 3 Jirka Klimes 2013-07-15 14:49:49 UTC
Dan Williams fixed this in http://koji.fedoraproject.org/koji/buildinfo?buildID=425333

Comment 4 Fedora Update System 2013-07-16 15:45:38 UTC
NetworkManager-vpnc-0.9.8.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/NetworkManager-vpnc-0.9.8.2-1.fc19

Comment 5 Fedora Update System 2013-07-17 03:14:20 UTC
Package NetworkManager-vpnc-0.9.8.2-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing NetworkManager-vpnc-0.9.8.2-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-13125/NetworkManager-vpnc-0.9.8.2-1.fc19
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-07-26 00:27:16 UTC
NetworkManager-vpnc-0.9.8.2-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.