Bug 950623

Summary: [NetKVM] Review "TestOnly" parameters and remove those that shouldn't be exposed to the user
Product: Red Hat Enterprise Linux 6 Reporter: Yvugenfi <yvugenfi>
Component: virtio-winAssignee: Yvugenfi <yvugenfi>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.5CC: acathrow, bcao, bsarathy, lnovich, mdeng, qzhang, vrozenfe, yvugenfi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virtio-win-prewhql-0.1-59 Doc Type: Bug Fix
Doc Text:
Cause: Debug parameters were exposed to the user. Consequence: User could have change those parameters without fully understanding the consequence of the actions and thus break network device functionality. Fix: Remove test parameters from device manager. Result: User no longer is exposed to debug and experimental parameters.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-22 00:07:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yvugenfi@redhat.com 2013-04-10 13:58:06 UTC 
Description of problem:

We are exposing several debug parameters for NetKVM driver. They should be reviewed and those that are not used or can cause a user confusion should be removed.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Yvugenfi@redhat.com 2013-04-10 16:02:07 UTC 
Removing DPCChecker:

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=fc0c5c4749d793e426023b13a629c768969b435f
Comment 2 Yvugenfi@redhat.com 2013-04-10 17:05:42 UTC 
Removing TestOnly.DelayConnect(ms):

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=5feb7ee187bdead79774a919fd0c48a250f14456
Comment 3 Yvugenfi@redhat.com 2013-04-10 19:32:20 UTC 
Removing "TestOnly.InterruptRecovery":

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=223afaa45c07ce333d980ca9dade6583139b5883
Comment 4 Yvugenfi@redhat.com 2013-04-10 20:32:19 UTC 
Removing "TestOnly.Promiscuous":
http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=1aaba12bbdc43bda0c5031622e225be6ba9135b3
Comment 5 Yvugenfi@redhat.com 2013-04-10 23:29:06 UTC 
Removing "Init.UseMergedBuffers". The guest will always try to use mergable buffer (the check if the host suppors this feature remains in the code):

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=ad2356ced698f02a073f2ec276f8890a423bbd5e
Comment 6 Yvugenfi@redhat.com 2013-04-10 23:29:45 UTC 
Removing "TestOnly.HwPacketFilter":

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=8c2edb1704e27b8486978c23cd59eae504eee4e7
Comment 7 Yvugenfi@redhat.com 2013-04-10 23:30:03 UTC 
Removing remains of DPCChecker:

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=ab6c51acaf1b44c3939873f8fae2a5374bebef66
Comment 8 Yvugenfi@redhat.com 2013-04-11 10:40:37 UTC 
Removing "Init.UsePublishEvents", will check host settings:

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=1f4faf7957135e5732ef081b38f55ea2c7874cf5
Comment 9 Yvugenfi@redhat.com 2013-04-11 10:42:07 UTC 
Removing "TestOnly.GuestChecksum":

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=6dc0ab1d022fbb291551d9885187c9d253536ee0
Comment 10 Yvugenfi@redhat.com 2013-04-11 10:42:47 UTC 
Removing "TestOnly.Scatter-Gather":

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=e886e301927434bfdd4e372953ab4ecd2fd3eb4c
Comment 11 Yvugenfi@redhat.com 2013-04-11 10:43:17 UTC 
Removing "TestOnly.AnalyzeIPPackets":

http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=d18d22fee716a21576f14d87869ce143e6b3446f
Comment 12 Yvugenfi@redhat.com 2013-04-11 11:24:33 UTC 
The change is for drivers for Vista and up. Windows XP and Windows 2003 will have "old" parameters.
Comment 13 Min Deng 2013-04-25 03:09:14 UTC 
   Re-test the bug on win7/8/2k8/2012 platform via build 59,the above parameters has been removed.
   Actual results,the parameters were removed
   Expected results,the parameters are removed
   So the issue has been fixed,thanks.
Comment 14 Mike Cao 2013-05-30 03:34:42 UTC 
Based on comment #13 ,move status to VERIFIED.
Comment 21 errata-xmlrpc 2013-11-22 00:07:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1729.html