Red Hat Bugzilla – Bug 950623
[NetKVM] Review "TestOnly" parameters and remove those that shouldn't be exposed to the user
Last modified: 2013-12-06 02:42:44 EST
Description of problem: We are exposing several debug parameters for NetKVM driver. They should be reviewed and those that are not used or can cause a user confusion should be removed. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Removing DPCChecker: http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=fc0c5c4749d793e426023b13a629c768969b435f
Removing TestOnly.DelayConnect(ms): http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=5feb7ee187bdead79774a919fd0c48a250f14456
Removing "TestOnly.InterruptRecovery": http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=223afaa45c07ce333d980ca9dade6583139b5883
Removing "TestOnly.Promiscuous": http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=1aaba12bbdc43bda0c5031622e225be6ba9135b3
Removing "Init.UseMergedBuffers". The guest will always try to use mergable buffer (the check if the host suppors this feature remains in the code): http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=ad2356ced698f02a073f2ec276f8890a423bbd5e
Removing "TestOnly.HwPacketFilter": http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=8c2edb1704e27b8486978c23cd59eae504eee4e7
Removing remains of DPCChecker: http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=ab6c51acaf1b44c3939873f8fae2a5374bebef66
Removing "Init.UsePublishEvents", will check host settings: http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=1f4faf7957135e5732ef081b38f55ea2c7874cf5
Removing "TestOnly.GuestChecksum": http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=6dc0ab1d022fbb291551d9885187c9d253536ee0
Removing "TestOnly.Scatter-Gather": http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=e886e301927434bfdd4e372953ab4ecd2fd3eb4c
Removing "TestOnly.AnalyzeIPPackets": http://git.engineering.redhat.com/?p=users/yvugenfi/internal-kvm-guest-drivers-windows/.git;a=commit;h=d18d22fee716a21576f14d87869ce143e6b3446f
The change is for drivers for Vista and up. Windows XP and Windows 2003 will have "old" parameters.
Re-test the bug on win7/8/2k8/2012 platform via build 59,the above parameters has been removed. Actual results,the parameters were removed Expected results,the parameters are removed So the issue has been fixed,thanks.
Based on comment #13 ,move status to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-1729.html