Bug 950907
| Summary: | Review Request: python-jedi - Python auto-completion | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Hracek <phracek> |
| Component: | Package Review | Assignee: | Robert Kuska <rkuska> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 19 | CC: | jberan, notting, package-review |
| Target Milestone: | --- | Flags: | rkuska:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-jedi-0.5b5-3.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-30 04:32:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Hracek
2013-04-11 07:47:40 UTC
I am taking this. - Url shouldn't be link to source code, use [1]. - Fix python-devel to python2-devel [2]. - Rpmlint returns 'python-jedi.src: W: invalid-license LGPL', LGPLv3 is the right one [3], and few typos, use rpmlint on src.rpm. - I see that there are tests on github [4], did you run them before packaging? Also add please comment about tests run into spec file. [1] https://jedi.readthedocs.org/en/latest/index.html [2] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires [3] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses [4] https://github.com/davidhalter/jedi/tree/master/test Hi, URL has been updated as well as BuildRequires section. rpmlint has been run on src.rpm. This was not done before. Tests comments are mentioned in changelog. SPEC: http://phracek.fedorapeople.org/python-jedi/python-jedi.spec SRPM: http://phracek.fedorapeople.org/python-jedi/python-jedi-0.5b5-2.fc18.src.rpm - For first, I am sorry for misleading comment about tests. Proper way to do this is checkout the source code, make archive and add it as another Source into spec. Check this [1] for an inspiration. - I can't approve broken package, according the info you provided, some tests fail. [1] http://pkgs.fedoraproject.org/cgit/rubygem-activesupport.git/tree/rubygem-activesupport.spec On the base of upstream discussion (https://github.com/davidhalter/jedi/issues/200) Test Suite if available only in dev branch. SPEC: http://phracek.fedorapeople.org/python-jedi/python-jedi.spec SPRM: http://phracek.fedorapeople.org/python-jedi/python-jedi-0.5b5-3.fc18.src.rpm Looks good. Approved. New Package SCM Request ======================= Package Name: python-jedi Short Description: Python auto-completion Owners: phracek Branches: f19 Use your FAS account name, not email address. New Package SCM Request ======================= Package Name: python-jedi Short Description: Python auto-completion Owners: phracek Branches: f19 Git done (by process-git-requests). python-jedi-0.5b5-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-jedi-0.5b5-3.fc19 Package has been imported scm-commit (http://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130422/1004863.html) python-jedi-0.5b5-3.fc19 has been pushed to the Fedora 19 testing repository. python-jedi-0.5b5-3.fc19 has been pushed to the Fedora 19 stable repository. |