Spec URL: http://phracek.fedorapeople.org/python-jedi/python-jedi.spec SRPM URL: http://phracek.fedorapeople.org/python-jedi/python-jedi-0.5b5-1.fc18.src.rpm Description: Jedi is an autocompletion tool for Python. It understands almost all of the basic Python syntax elements including many builtins. Fedora Account System Username:phracek [stone@kiasportyw jedi-master]$ rpmlint -v python-jedi.spec python-jedi.spec: I: checking-url http://pypi.python.org/packages/source/j/jedi/jedi-0.5b5.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [stone@kiasportyw jedi-master]$
I am taking this.
- Url shouldn't be link to source code, use [1]. - Fix python-devel to python2-devel [2]. - Rpmlint returns 'python-jedi.src: W: invalid-license LGPL', LGPLv3 is the right one [3], and few typos, use rpmlint on src.rpm. - I see that there are tests on github [4], did you run them before packaging? Also add please comment about tests run into spec file. [1] https://jedi.readthedocs.org/en/latest/index.html [2] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires [3] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses [4] https://github.com/davidhalter/jedi/tree/master/test
Hi, URL has been updated as well as BuildRequires section. rpmlint has been run on src.rpm. This was not done before. Tests comments are mentioned in changelog. SPEC: http://phracek.fedorapeople.org/python-jedi/python-jedi.spec SRPM: http://phracek.fedorapeople.org/python-jedi/python-jedi-0.5b5-2.fc18.src.rpm
- For first, I am sorry for misleading comment about tests. Proper way to do this is checkout the source code, make archive and add it as another Source into spec. Check this [1] for an inspiration. - I can't approve broken package, according the info you provided, some tests fail. [1] http://pkgs.fedoraproject.org/cgit/rubygem-activesupport.git/tree/rubygem-activesupport.spec
On the base of upstream discussion (https://github.com/davidhalter/jedi/issues/200) Test Suite if available only in dev branch. SPEC: http://phracek.fedorapeople.org/python-jedi/python-jedi.spec SPRM: http://phracek.fedorapeople.org/python-jedi/python-jedi-0.5b5-3.fc18.src.rpm
Looks good. Approved.
New Package SCM Request ======================= Package Name: python-jedi Short Description: Python auto-completion Owners: phracek Branches: f19
Use your FAS account name, not email address.
Git done (by process-git-requests).
python-jedi-0.5b5-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-jedi-0.5b5-3.fc19
Package has been imported scm-commit (http://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130422/1004863.html)
python-jedi-0.5b5-3.fc19 has been pushed to the Fedora 19 testing repository.
python-jedi-0.5b5-3.fc19 has been pushed to the Fedora 19 stable repository.