Bug 951250
| Summary: | Review Request: R-sandwich - Robust Covariance Matrix Estimators | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre-YvesChibon <pingou> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, orion, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-17 04:24:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pierre-YvesChibon
2013-04-11 20:12:09 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5243569 == REVIEW ==
Good:
- rpmlint checks return:
R-sandwich.src:45: W: macro-in-comment %check
R-sandwich.src:46: W: macro-in-comment %{_bindir}
R-sandwich.src:46: W: macro-in-comment %{packname}
All safe to ignore (but feel free to %% them to make these warnings go away)
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK
- spec file legible, in am. english
- source matches upstream 0a99d0c4b1fbb25655cb26c65358a9f9055bccd1b398cb5b0813810b961df69b
- package compiles on f18 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
Thanks for the review spot New Package SCM Request ======================= Package Name: R-sandwich Short Description: Robust covariance matrix estimators Owners: pingou spot Branches: f19, devel Git done (by process-git-requests). Package Change Request ====================== Package Name: R-sandwich New Branches: el5 el6 Owners: pingou spot InitialCC: Git done (by process-git-requests). Package Change Request ====================== Package Name: R-sandwich New Branches: f18 Owners: pingou spot InitialCC: Git done (by process-git-requests). This has been built |