Bug 951250 - Review Request: R-sandwich - Robust Covariance Matrix Estimators
Summary: Review Request: R-sandwich - Robust Covariance Matrix Estimators
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-11 20:12 UTC by Pierre-YvesChibon
Modified: 2013-10-17 04:24 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-10-17 04:24:31 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Pierre-YvesChibon 2013-04-11 20:12:09 UTC
Spec URL: http://pingou.fedorapeople.org/RPMs//R-sandwich.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs//R-sandwich-2.2.10-1.el6.src.rpm

Description:
Model-robust standard error estimators for cross-sectional, time series
and longitudinal data.

Comment 1 Pierre-YvesChibon 2013-04-11 20:12:20 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=5243569

Comment 2 Tom "spot" Callaway 2013-04-11 20:25:43 UTC
== REVIEW ==

Good:

- rpmlint checks return:
R-sandwich.src:45: W: macro-in-comment %check
R-sandwich.src:46: W: macro-in-comment %{_bindir}
R-sandwich.src:46: W: macro-in-comment %{packname}

All safe to ignore (but feel free to %% them to make these warnings go away)
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK
- spec file legible, in am. english
- source matches upstream 0a99d0c4b1fbb25655cb26c65358a9f9055bccd1b398cb5b0813810b961df69b
- package compiles on f18 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.

Comment 3 Pierre-YvesChibon 2013-04-11 20:43:25 UTC
Thanks for the review spot

New Package SCM Request
=======================
Package Name: R-sandwich
Short Description: Robust covariance matrix estimators
Owners: pingou spot
Branches: f19, devel

Comment 4 Gwyn Ciesla 2013-04-12 11:54:11 UTC
Git done (by process-git-requests).

Comment 5 Tom "spot" Callaway 2013-04-18 02:56:08 UTC
Package Change Request
======================
Package Name: R-sandwich
New Branches: el5 el6
Owners: pingou spot
InitialCC:

Comment 6 Gwyn Ciesla 2013-04-18 14:16:47 UTC
Git done (by process-git-requests).

Comment 7 Tom "spot" Callaway 2013-04-20 20:34:55 UTC
Package Change Request
======================
Package Name: R-sandwich
New Branches: f18
Owners: pingou spot
InitialCC:

Comment 8 Gwyn Ciesla 2013-04-22 13:26:39 UTC
Git done (by process-git-requests).

Comment 9 Orion Poplawski 2013-10-17 04:24:31 UTC
This has been built


Note You need to log in before you can comment on or make changes to this bug.