Bug 951777
| Summary: | Review Request: python-pygal - A python svg graph plotting library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Pierre-YvesChibon <pingou> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, pingou |
| Target Milestone: | --- | Flags: | pingou:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-28 13:03:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 951775, 952851 | ||
| Bug Blocks: | |||
|
Description
Ralph Bean
2013-04-13 04:44:36 UTC
Looking at the README and the header of the source the appropriate license tag appears to be LGPLv3+, maybe upstream would want to precise this in the setup.py I am surprised by the difference between the list of BuildRequires and Requires. Are all the additionnal libraries in BR really only required for the tests? Otherwise: * package meets naming guidelines * package meets packaging guidelines * spec is clean * license LGPLv3+ is fine (license tag needs to be adjusted) * source matches upstream: 89269d33251cdc70543469421f8969a8fc284337 * no missing BR * no unnecessary BR * no locales * not relocatable * owns all directories that it creates * no duplicate files * permissions ok * macro use consistent * code, not content * no need for -docs * nothing in %doc affects runtime * no need for .desktop file I'll need to test how it compiles with python-cairosvg Builds fine on F18 with python-cairosvg installed and imports fine I'll wait to approve cairosvg to approve this one. Asked about license clarification here -> https://github.com/Kozea/pygal/pull/32 Updated license field. Spec URL: http://threebean.org/rpm/python-pygal.spec SRPM URL: http://threebean.org/rpm/python-pygal-0.13.0-2.fc18.src.rpm Ok the tests are actually not shipped with the source, so the licensing for the rpm is good. This package is APPROVED New Package SCM Request ======================= Package Name: python-pygal Short Description: A python svg graph plotting library Owners: ralph Branches: f19 f18 f17 el6 InitialCC: Git done (by process-git-requests). python-pygal-0.13.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pygal-0.13.0-2.fc19 python-pygal-0.13.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pygal-0.13.0-2.fc18 python-pygal-0.13.0-2.fc19 has been pushed to the Fedora 19 stable repository. python-pygal-0.13.0-2.fc18 has been pushed to the Fedora 18 stable repository. All stable. |