Bug 951775 - Review Request: python-cairosvg - A Simple SVG Converter for Cairo
Summary: Review Request: python-cairosvg - A Simple SVG Converter for Cairo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 951777
TreeView+ depends on / blocked
 
Reported: 2013-04-13 04:31 UTC by Ralph Bean
Modified: 2013-05-04 00:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-03 01:24:47 UTC
Type: ---
Embargoed:
pingou: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralph Bean 2013-04-13 04:31:46 UTC
Spec URL: http://ralph.fedorapeople.org//python-cairosvg.spec
SRPM URL: http://ralph.fedorapeople.org//python-cairosvg-0.5-1.fc18.src.rpm

Description:
CairoSVG is a SVG converter based on Cairo. It can export SVG files to PDF,
PostScript and PNG files.

For further information, please visit the `CairoSVG Website
<http://www.cairosvg.org/>`_.

Comment 1 Ralph Bean 2013-04-13 04:31:52 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=5247671

Comment 2 Pierre-YvesChibon 2013-04-14 08:36:36 UTC
Looking at the header of the source the appropriate license tag appears to be LGPLv3+, maybe upstream would want to precise this in the setup.py

The files for the tests are licensed under BSD 3-clauses, so the license tag might need to be adjusted accordingly (but if the tests are not installed on the filesystem, maybe not, maybe worth to ask spot about this).

Btw, any reason to mark the link in the %description in this way?

Otherwise:
* package meets naming guidelines (you can use %{modname} is some more places if you like)
* package meets packaging guidelines
* spec is clean
* license LGPLv3+ is fine (license tag needs to be adjusted)
* source matches upstream:
6c092cce2b2ade47054aea6657173cbf
* builds fine on rawhide and F18
* no missing BR
* no unnecessary BR
* no locales
* not relocatable
* owns all directories that it creates
* no duplicate files
* permissions ok
* macro use consistent
* code, not content
* no need for -docs
* nothing in %doc affects runtime
* no need for .desktop file 


Let's clear up the how the License should be and I'll approve the package.

Comment 3 Ralph Bean 2013-04-15 17:35:16 UTC
I asked about license clarification here -> https://github.com/Kozea/CairoSVG/pull/8

Comment 4 Ralph Bean 2013-04-16 15:00:30 UTC
I got clarification from upstream.  LGPLv3+ it is.

Also, I removed the reStructuredText markup from the description.

Spec URL: http://threebean.org/rpm/python-cairosvg.spec
SRPM URL: http://threebean.org/rpm/python-cairosvg-0.5-2.fc18.src.rpm

Comment 5 Pierre-YvesChibon 2013-04-16 15:24:11 UTC
This package is APPROVED

Comment 6 Ralph Bean 2013-04-16 15:27:06 UTC
New Package SCM Request
=======================
Package Name: python-cairosvg
Short Description: A Simple SVG Converter for Cairo
Owners: ralph
Branches: f19 f18 f17 el6
InitialCC:

Comment 7 Gwyn Ciesla 2013-04-16 15:39:39 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2013-04-16 18:08:54 UTC
python-cairosvg-0.5-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-cairosvg-0.5-2.fc19

Comment 9 Fedora Update System 2013-04-16 18:09:16 UTC
python-cairosvg-0.5-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-cairosvg-0.5-2.fc18

Comment 10 Fedora Update System 2013-04-16 18:09:42 UTC
python-cairosvg-0.5-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-cairosvg-0.5-2.fc17

Comment 11 Fedora Update System 2013-04-16 18:10:19 UTC
python-cairosvg-0.5-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-cairosvg-0.5-2.el6

Comment 12 Fedora Update System 2013-05-02 19:51:55 UTC
python-cairosvg-0.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 13 Fedora Update System 2013-05-03 02:45:12 UTC
python-cairosvg-0.5-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2013-05-03 23:58:07 UTC
python-cairosvg-0.5-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 15 Fedora Update System 2013-05-04 00:00:04 UTC
python-cairosvg-0.5-2.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.