Bug 952602

Summary: modifyrepo does not accept the same command-line options as createrepo
Product: Red Hat Enterprise Linux 6 Reporter: J.H.M. Dassen (Ray) <rdassen>
Component: createrepoAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED ERRATA QA Contact: Stanislav Zidek <szidek>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.4CC: aupadhye, hartsjc, james.antill, jzeleny, ksrot, lmacken, mmello, mschuppe, packaging-team-maint, rbinkhor, szidek, thomas.oulevey, tlavigne, vmukhame
Target Milestone: rcKeywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: createrepo-0.9.9-19.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 948771 Environment:
Last Closed: 2014-05-14 13:41:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 948771    
Bug Blocks: 835616, 994246    

Description J.H.M. Dassen (Ray) 2013-04-16 09:35:41 UTC
+++ This bug was initially created as a clone of Bug #948771 +++

Created attachment 731888 [details]
patch

Description of problem:

createrepo-0.9.9-17.el6.noarch 

modifyrepo does not accept the same option as createrepo.
We are especially interested in 
--simple-md-filenames
--checksum

Version-Release number of selected component (if applicable):

0.9.9-17.el6 
but
My patch is against GIT HEAD.

How reproducible:

Option are not available.

Steps to Reproduce:
1.modifyrepo --simple-md-filenames --checksum sha

Actual results:

Option not available.

Expected results:

Option available.

--- Additional comment from Thomas Oulevey on 2013-04-05 08:37:45 EDT ---

Created attachment 731897 [details]
createrepo-modifyrepo-sha-simplemd_v2.diff

First patch had an error.

--- Additional comment from Thomas Oulevey on 2013-04-05 08:42:52 EDT ---

Created attachment 731898 [details]
createrepo-modifyrepo-sha-simplemd_v3.diff

--- Additional comment from Zdeněk Pavlas on 2013-04-05 09:32:50 EDT ---

Thanks, somewhat modifed and merged.  The --simple-md-filenames and --unique-md-filenames options are complementary, we should support both.  Also updated --help, to show --unique is the default.

--- Additional comment from Thomas Oulevey on 2013-04-05 09:58:33 EDT ---

There is an issue on line 189 :
-    parser.add_option("--simple-md-filenames", dest="unique_md_filenames",
+    parser.add_option("--simple-md-filenames", dest="simple_md_filenames",

--- Additional comment from Zdeněk Pavlas on 2013-04-05 10:05:22 EDT ---

Yeah, that's intended :)  Both options share the same destination variable, but there's a different action- store_true vs store_false.  I find this easier than handling two independent options later on.

--- Additional comment from Thomas Oulevey on 2013-04-05 10:11:44 EDT ---

Sorry, me not reading the full line :)
Thanks! works great.

I asked my TAM for a backport on el6 packages.

Comment 8 Valentina Mukhamedzhanova 2014-04-03 08:26:47 UTC
*** Bug 966999 has been marked as a duplicate of this bug. ***

Comment 9 James Antill 2014-04-07 15:31:45 UTC
*** Bug 962547 has been marked as a duplicate of this bug. ***

Comment 12 errata-xmlrpc 2014-05-14 13:41:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0491.html