Bug 953199

Summary:	Environment scripts not preserved on upgrade
Product:	[Fedora] Fedora	Reporter:	Alicja Kario <hkario>
Component:	environment-modules	Assignee:	Orion Poplawski <orion>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	jsynacek, orion
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	953198	Environment:
Last Closed:	2013-04-17 17:29:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	953198, 976349
Bug Blocks:

Description Alicja Kario 2013-04-17 15:36:48 UTC

+++ This bug was initially created as a clone of Bug #953198 +++

Description of problem:
While updating package environment-modules changes to environment scripts are not preserved.

Version-Release number of selected component (if applicable):
environment-modules-3.2.9c-4.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Install environment-modules
2. Change /etc/profile.d/modules.csh or /etc/profile.d/modules.sh
3. Perform package reinstall
  
Actual results:
All changes to files are lost.

Expected results:
Changes should be preserved

Additional info:
Present also on Fedora 18

Comment 1 Orion Poplawski 2013-04-17 16:06:17 UTC

Well, you really shouldn't be modifying those files.  Why are you?

Comment 2 Alicja Kario 2013-04-17 16:16:44 UTC

This was discovered during testing some other issue.

Those files are in /etc/ so I'd guess any changes to them shouldn't be silently dropped, but that's just my opinion.

When I asked Jan Synacek <jsynacek> if silently replacing them is correct behaviour he answered:

I don't think this behavior can be said to be 'correct'. If you think those files should be marked as config(noreplace) files, please, file a separate bugzilla and clone it for Fedora rawhide.

Comment 3 Orion Poplawski 2013-04-17 17:29:49 UTC

Yeah, sounds good.  Marked as %config(noreplace)