Bug 955088

*** Bug 872966 has been marked as a duplicate of this bug. ***

%files	Faenza
# Own all directories
%{_datadir}/icons/Faenza/

This folder is already owned by faenza-icon-theme. Wouldn't it be better to pull this as a dependency and let spacefm-Faenza only own the contents of this folder? It doesn't make any sense to have a few Faenza icons for a single application. To use these icons, users will need to install the whole faenza-icon-theme package anyway.

Okay.

http://mtasaka.fedorapeople.org/Review_request/spacefm/spacefm-0.8.7-2.fc.src.rpm
http://mtasaka.fedorapeople.org/Review_request/spacefm/spacefm.spec

* Tue Apr 23 2013 Mamoru TASAKA <mtasaka> - 0.8.7-2
- Make -Faenza subpackage depend on faenza-icon-theme
- Create skeleton configuration file and directory

Scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5293322

$ rpmlint -i -v *
spacefm.i686: I: checking
spacefm.i686: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: W: spelling-error %description -l en_US customizable -> customization
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: I: checking-url http://ignorantguru.github.io/spacefm/ (timeout 10 seconds)
spacefm.i686: E: zero-length /etc/spacefm/spacefm.conf
spacefm.i686: W: no-manual-page-for-binary spacefm-auth
Each executable in standard binary directories should have a man page.

spacefm.i686: W: no-manual-page-for-binary spacefm
Each executable in standard binary directories should have a man page.

spacefm.x86_64: I: checking
spacefm.x86_64: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: W: spelling-error %description -l en_US customizable -> customization
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: I: checking-url http://ignorantguru.github.io/spacefm/ (timeout 10 seconds)
spacefm.x86_64: E: zero-length /etc/spacefm/spacefm.conf
spacefm.x86_64: W: no-manual-page-for-binary spacefm-auth
Each executable in standard binary directories should have a man page.

spacefm.x86_64: W: no-manual-page-for-binary spacefm
Each executable in standard binary directories should have a man page.

spacefm.src: I: checking
spacefm.src: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: W: spelling-error %description -l en_US customizable -> customization
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: I: checking-url http://ignorantguru.github.io/spacefm/ (timeout 10 seconds)
spacefm.src: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.7.tar.xz (timeout 10 seconds)
spacefm-debuginfo.i686: I: checking
spacefm-debuginfo.i686: I: checking-url http://ignorantguru.github.io/spacefm/ (timeout 10 seconds)
spacefm-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.7/src/desktop/working-area.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

spacefm-debuginfo.x86_64: I: checking
spacefm-debuginfo.x86_64: I: checking-url http://ignorantguru.github.io/spacefm/ (timeout 10 seconds)
spacefm-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.7/src/desktop/working-area.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

spacefm-Faenza.noarch: I: checking
spacefm-Faenza.noarch: I: checking-url http://ignorantguru.github.io/spacefm/ (timeout 10 seconds)
spacefm-Faenza.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

spacefm.spec: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.7.tar.xz (timeout 10 seconds)
6 packages and 1 specfiles checked; 4 errors, 17 warnings.


Don't bother with incorrect FSF addresses. Just inform the upstream developers to fix this in future versions.

No docs in the faenza subpackage, ignorable spelling errors, missing manpages, no problem at all.

You have added a skeleton config file. But what's the advantage of having an empty global config file?

(In reply to comment #4)
> You have added a skeleton config file. But what's the advantage of having an
> empty global config file?

src/settings.c and src/vfs/vfs-file-task.c says (seems to be saying) that spacefm sometimes (when run with privilege mode) writes /etc/spacefm/spacefm.conf, so at least /etc/spacefm should be owned and creating skeleton spacefm.conf is preferable to show that rpm "tracks" this file.

Note that it seems that when run as privilege mode spacefm may create /etc/spacefm/%s-as-root (%s is substituted with each user), however %s may change in various ways and I don't think (and I cannot find good way) to own this type of files.

(In reply to comment #5)
> (In reply to comment #4)
> > You have added a skeleton config file. But what's the advantage of having an
> > empty global config file?
> 
> src/settings.c and src/vfs/vfs-file-task.c says (seems to be saying) that
> spacefm sometimes (when run with privilege mode) writes
> /etc/spacefm/spacefm.conf, so at least /etc/spacefm should be owned and
> creating skeleton spacefm.conf is preferable to show that rpm "tracks" this
> file.
> 
> Note that it seems that when run as privilege mode spacefm may create
> /etc/spacefm/%s-as-root (%s is substituted with each user), however %s may
> change in various ways and I don't think (and I cannot find good way) to own
> this type of files.

OK, let's assume the package owns /etc/spacefm/. This folder is empty at install time, but once SpaceFM has stored any data there, the package manager is unable to remove the folder when uninstalling SpaceFM. Usually, an application ships a global configuration file directly, and this folder has to marked with %config(noreplace) in the file list then. And in this case the folder can't even be removed so that it remains on the system anyway. However, your targeted behavior doesn't break anything, so the <PACKAGE IS APPROVED>.

Thank you!

New Package SCM Request
=======================
Package Name: spacefm
Short Description: Multi-panel tabbed file and desktop manager
Owners: mtasaka
Branches: f17 f18 f19
InitialCC:

Git done (by process-git-requests).

Built on all branches, push requested for non-rawhide branches, closing.
Thank you for review and git procedure.