Spec URL: https://raw.github.com/Ignotus/fedora-packages/39aebc61f68246267bd45368f6754076eb30ba66/spacefm/spacefm.spec SRPM URL: https://dl.dropbox.com/s/ektpydeahssv58b/spacefm-0.8.2-1.fc17.src.rpm?dl=1 Description: SpaceFM is a multi-panel tabbed file manager for Linux with built-in VFS, udev-based device manager, customizable menu system, and bash integration. Fedora Account System Username: minh
%{_datadir}/applications/spacefm-find.desktop %{_datadir}/applications/spacefm-folder-handler.desktop You need at least desktop-file-validate to install these files. Add desktop-file-utils to BuildRequires. Because the files contain a MimeType key and add a new MIME type anyway, you must add some scriptlets: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo Drop gettext from BuildRequires, it's a recursive dependency of intltool. %setup -qn %{name}-%{version} The %{name}-%{version} macro is unneeded, it's the default.
Upd. Spec: https://raw.github.com/Ignotus/fedora-packages/1a6861ceade0010a842e66bbaf7841b269c87f56/spacefm/spacefm.spec For building a new SRPM archive, please use this script https://raw.github.com/Ignotus/fedora-packages/1a6861ceade0010a842e66bbaf7841b269c87f56/spacefm/BUILD.sh (place it in the same directory as the spacefm.spec
You can also drop xz from the BuildRequires, it's already part of the minimal build dependencies. You could enable startup-notification support by adding startup-notification-devel to the BuildRequires. License is incorrect, there is no dual-licensing: spacefm source code is GPLv2+ but contains parts licensed under LGPLv2+. License tag should be: # spacefm exo module is LGPLv2+ License: GPLv2+ and LGPLv2+ Take advantage of macros, especially in Source0, to make future updates of your package easier: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.xz
>Take advantage of macros, especially in Source0, to make future updates of your package easier: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.xz it's easier for future updates but not easier for future URL copy-pasting for downloading a source archive :)
Fixed Spec: https://raw.github.com/Ignotus/fedora-packages/bceaa135d65ef1a5716e3aa7849556b1e22c0172/spacefm/spacefm.spec
(In reply to comment #2) > Upd. > Spec: > https://raw.github.com/Ignotus/fedora-packages/ > 1a6861ceade0010a842e66bbaf7841b269c87f56/spacefm/spacefm.spec > > For building a new SRPM archive, please use this script > https://raw.github.com/Ignotus/fedora-packages/ > 1a6861ceade0010a842e66bbaf7841b269c87f56/spacefm/BUILD.sh (place it in the > same directory as the spacefm.spec Please provide clickable links to download your files directly. I don't want to create a srpm this way. Reviewers need real files, not instructions to create them.
SRPM: https://dl.dropbox.com/s/4ypsiwdga6vlfwu/spacefm-0.8.2-3.fc17.src.rpm?dl=1
(In reply to comment #7) > SRPM: > https://dl.dropbox.com/s/4ypsiwdga6vlfwu/spacefm-0.8.2-3.fc17.src.rpm?dl=1 Here's small random notes: 1. 0.8-2-3 in changelog should be 0.8.2-3 2. INSTALL is not required here (it's for manual build/installation) 3. NEWS is empty file, you can remove it. Package build OK on mock/koji, there's a bunch of warrings during the compilation [1] but that's not a blocker (probably, should reported to upstream). http://kojipkgs.fedoraproject.org//work/tasks/6882/4676882/build.log
(In reply to comment #8) > (In reply to comment #7) > > SRPM: > > https://dl.dropbox.com/s/4ypsiwdga6vlfwu/spacefm-0.8.2-3.fc17.src.rpm?dl=1 > > Here's small random notes: > > 1. 0.8-2-3 in changelog should be 0.8.2-3 > 2. INSTALL is not required here (it's for manual build/installation) > 3. NEWS is empty file, you can remove it. > > > Package build OK on mock/koji, there's a bunch of warrings during the > compilation [1] but that's not a blocker (probably, should reported to > upstream). > > http://kojipkgs.fedoraproject.org//work/tasks/6882/4676882/build.log SPEC: https://raw.github.com/Ignotus/fedora-packages/8dcb817d4abafb31f026faaa67b49a5126f321a1/spacefm/spacefm.spec SRPM: https://dl.dropbox.com/s/6isnq0tc4binw46/spacefm-0.8.2-4.fc17.src.rpm?dl=1
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4833692 $ rpmlint -i -v * spacefm.src: I: checking spacefm.src: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.src: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.src: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.2.tar.xz (timeout 10 seconds) spacefm.i686: I: checking spacefm.i686: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: incoherent-version-in-changelog 0.8-2-4 ['0.8.2-4.fc19', '0.8.2-4'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. spacefm.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.i686: W: no-manual-page-for-binary spacefm-auth Each executable in standard binary directories should have a man page. spacefm.i686: W: no-manual-page-for-binary spacefm Each executable in standard binary directories should have a man page. spacefm.x86_64: I: checking spacefm.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: incoherent-version-in-changelog 0.8-2-4 ['0.8.2-4.fc19', '0.8.2-4'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. spacefm.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.x86_64: W: no-manual-page-for-binary spacefm-auth Each executable in standard binary directories should have a man page. spacefm.x86_64: W: no-manual-page-for-binary spacefm Each executable in standard binary directories should have a man page. spacefm-debuginfo.i686: I: checking spacefm-debuginfo.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.2/src/desktop/working-area.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. spacefm-debuginfo.x86_64: I: checking spacefm-debuginfo.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.2/src/desktop/working-area.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. spacefm.spec: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.2.tar.xz (timeout 10 seconds) 5 packages and 1 specfiles checked; 2 errors, 15 warnings. The missing man page is no problem. It is not up to you to create it. But maybe you should inform the upstream folks. The same for the old FSF address. You might patch the source files (but not the COPYING files!), this is allowed by the packaging guidelines. But don't bother with them. Just inform the upstream developers so that they can fix it in future releases. "spacefm.i686: W: incoherent-version-in-changelog 0.8-2-4 ['0.8.2-4.fc19', '0.8.2-4']" Please fix this, has to be: 0.8.2-4 Source0: http://downloads.sourceforge.net/spacefm/spacefm-0.8.2.tar.xz Well, it's your choice to don't use macros for name and version here. But using macros makes it easier to update the package to a newer upstream version, and even after a possible name change. Not a review blocker, though.
BTW, a new version 0.8.4 is available from GitHub: https://github.com/IgnorantGuru/spacefm/tree/master/packages
Hello again Seems have been fixed in the new version. spacefm.src: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.src: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.src: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.4.tar.xz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. SPEC: https://raw.github.com/Ignotus/fedora-packages/master/spacefm/spacefm.spec SRPM: https://dl.dropbox.com/s/r7a0s8xmyujjqtg/spacefm-0.8.4-1.fc17.src.rpm?dl=1
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4871939 $ rpmlint -i -v * spacefm.src: I: checking spacefm.src: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.src: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.src: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.4.tar.xz (timeout 10 seconds) spacefm.i686: I: checking spacefm.i686: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.i686: W: no-manual-page-for-binary spacefm-auth Each executable in standard binary directories should have a man page. spacefm.i686: W: no-manual-page-for-binary spacefm Each executable in standard binary directories should have a man page. spacefm.x86_64: I: checking spacefm.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.x86_64: W: no-manual-page-for-binary spacefm-auth Each executable in standard binary directories should have a man page. spacefm.x86_64: W: no-manual-page-for-binary spacefm Each executable in standard binary directories should have a man page. spacefm-debuginfo.i686: I: checking spacefm-debuginfo.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.4/src/desktop/working-area.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. spacefm-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/spacefm-0.8.4/src/settings.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. spacefm-debuginfo.x86_64: I: checking spacefm-debuginfo.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.4/src/desktop/working-area.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. spacefm-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/spacefm-0.8.4/src/settings.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. spacefm.spec: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.4.tar.xz (timeout 10 seconds) 5 packages and 1 specfiles checked; 2 errors, 15 warnings. Most of the rpmlint messages are ignorable. But the file src/settings.c is executable, which is unneeded. Well, it doesn't land in the binary package, but it could cause undesired reactions if someone installs the debug package. You should remove the executable bit before building the binary (in the %prep section). Moreover, the package uses the folder %{_datadir}/icons/Faenza/apps/48/ but doesn't own. It is already owned by the package faenza-icon-theme. But imagine, someone doesn't like the Faenza icons and doesn't want to install an extra package. That's why I recommend to split out the Faenza icons into a subpackage which requires both spacefm and faenza-icon-theme. %doc %{_datadir}/doc/spacefm It is somewhat strange to have two doc folders. The first one (versioned) contains the usual stuff such as COPYING etc. and the second one contains the html files. Would be nice to have both in the versioned folder, if possible. Is there a way from the spacefm gui to open the html files? Or are they stand-alone? Perhaps spacefm has a configure switch to define the folder for the help files.
... and yesterday version 0.8.5 has been released :)
I have not found any URL in src/desktop/working-area.c . This is a copying text: /* * Guifications - The end all, be all, toaster popup plugin * Copyright (C) 2003-2004 Gary Kramlich * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version 2 * of the License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */
What is the status of this bug?
Minh, are you still interested in this package? If so, would you update your srpm to the latest version?
This review request seems to be dead. No response from the packager for almost four months. Mamoru, if you are interested in to pick it up, I will do the review.
(In reply to comment #18) > This review request seems to be dead. No response from the packager for > almost four months. Mamoru, if you are interested in to pick it up, I will > do the review. Okay, please find my renewed review request at bug 955088 . *** This bug has been marked as a duplicate of bug 955088 ***