Bug 955268

Summary: transmission package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: transmissionAssignee: Rahul Sundaram <metherid>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: abdulkarimmemon, bressers, charles, jspaleta, kumarpraveen.nitdgp, metherid, raghusiddarth, sanjay.ankur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-02 04:34:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
this should enable PIE none

Description Dhiru Kholia 2013-04-22 16:59:27 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently transmission is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

transmission-daemon-2.77-1.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py transmission-daemon-2.77-1.fc19.x86_64.rpm
transmission-daemon,transmission-daemon-2.77-1.fc19.x86_64.rpm,/usr/bin/transmission-daemon,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 1 Rahul Sundaram 2013-04-23 00:41:05 UTC 
fails with

DEBUG: /usr/bin/ld: about.o: relocation R_X86_64_32S against `_ZTV11AboutDialog' can not be used when making a shared object; recompile with -fPIC

i haven't looked further but i will be happy to take a spec file patch
Comment 2 Rahul Sundaram 2013-04-23 03:56:28 UTC 
failed scratch build for full logs

http://koji.fedoraproject.org/koji/taskinfo?taskID=5291401
Comment 3 Dhiru Kholia 2013-04-25 10:08:49 UTC 
Created attachment 739785 [details]
this should enable PIE
Comment 4 Dhiru Kholia 2013-04-25 10:10:20 UTC 
I have used shotgun approach here. Please make / find a better patch ;)
Comment 5 Rahul Sundaram 2013-04-25 19:43:27 UTC 
Thanks!  I fiddled with it and trimmed it down to the minimum necessary to make the build work with the right flags in place.  I am pushing a build out for Rawhide and F19 shortly.
Comment 6 Fedora Update System 2013-04-25 20:06:21 UTC 
transmission-2.77-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/transmission-2.77-3.fc19
Comment 7 Fedora Update System 2013-04-26 14:29:54 UTC 
Package transmission-2.77-3.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing transmission-2.77-3.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-6691/transmission-2.77-3.fc19
then log in and leave karma (feedback).
Comment 8 Fedora Update System 2013-05-02 04:34:45 UTC 
transmission-2.77-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.