Bug 955268 - transmission package should be built with PIE flags
Summary: transmission package should be built with PIE flags
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: transmission
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-22 16:59 UTC by Dhiru Kholia
Modified: 2014-03-25 03:44 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-05-02 04:34:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
this should enable PIE (19.94 KB, text/x-rpm-spec)
2013-04-25 10:08 UTC, Dhiru Kholia
no flags Details

Description Dhiru Kholia 2013-04-22 16:59:27 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently transmission is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

transmission-daemon-2.77-1.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py transmission-daemon-2.77-1.fc19.x86_64.rpm
transmission-daemon,transmission-daemon-2.77-1.fc19.x86_64.rpm,/usr/bin/transmission-daemon,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip

Comment 1 Rahul Sundaram 2013-04-23 00:41:05 UTC
fails with

DEBUG: /usr/bin/ld: about.o: relocation R_X86_64_32S against `_ZTV11AboutDialog' can not be used when making a shared object; recompile with -fPIC

i haven't looked further but i will be happy to take a spec file patch

Comment 2 Rahul Sundaram 2013-04-23 03:56:28 UTC
failed scratch build for full logs

http://koji.fedoraproject.org/koji/taskinfo?taskID=5291401

Comment 3 Dhiru Kholia 2013-04-25 10:08:49 UTC
Created attachment 739785 [details]
this should enable PIE

Comment 4 Dhiru Kholia 2013-04-25 10:10:20 UTC
I have used shotgun approach here. Please make / find a better patch ;)

Comment 5 Rahul Sundaram 2013-04-25 19:43:27 UTC
Thanks!  I fiddled with it and trimmed it down to the minimum necessary to make the build work with the right flags in place.  I am pushing a build out for Rawhide and F19 shortly.

Comment 6 Fedora Update System 2013-04-25 20:06:21 UTC
transmission-2.77-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/transmission-2.77-3.fc19

Comment 7 Fedora Update System 2013-04-26 14:29:54 UTC
Package transmission-2.77-3.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing transmission-2.77-3.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-6691/transmission-2.77-3.fc19
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-05-02 04:34:45 UTC
transmission-2.77-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.