Bug 955500

Summary:	Error message is unclear when attempting to restore a domain from a non-existent file
Product:	Red Hat Enterprise Linux 7	Reporter:	tingting zheng <tzheng>
Component:	libvirt	Assignee:	Laine Stump <laine>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.0	CC:	acathrow, cwei, dallan, dyuan, lsu, mzhan, ydu, zhwang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-1.0.5-2.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	851411	Environment:
Last Closed:	2014-06-13 12:22:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Comment 2 Laine Stump 2013-05-09 16:11:24 UTC

(The description of the bug was marked private. This is a sanitized version of the important parts of the description...)

libvirt-1.0.4-1.1.el7.x86_64

+++ This bug was initially created as a clone of Bug #851411 +++

Description of problem:
need clear error message when restore domain from the non-exist file

Version-Release number of selected component (if applicable):
libvirt-0.10.0-0rc1.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Restore a domain from the non-exist file
# ls /tmp/test
ls: cannot access /tmp/test: No such file or directory
# virsh restore /tmp/test
error: Failed to restore domain from /tmp/test
error: Failed to create file '/tmp/test': Operation not permitted

  
Actual results:
error: Failed to create file '/tmp/test': Operation not permitted

Expected results:
The error message should be like: 
cannot access /tmp/test: No such file or directory

Comment 3 Laine Stump 2013-05-10 17:12:56 UTC

The error message in question has been fixed in the following upstream commit, which will be in libvirt-1.0.5 and has also been pushed to the v1.0.5-maint branch:

commit a2c1bedbd8fa977dc733266e88a1b57e28b50dd3
Author: Laine Stump <laine>
Date:   Wed May 8 15:02:14 2013 -0400

    util: fix virFileOpenAs return value and resulting error logs

Comment 4 zhenfeng wang 2013-05-21 06:49:10 UTC

verified this bug on libvirt libvirt-1.0.5-2.el7.x86_64 
pkg info
kernel-3.9.0-0.55.el7.x86_64
qemu-kvm-1.4.0-4.el7.x86_64
libvirt-1.0.5-2.el7.x86_64

step
1 restore the guest from the non-exist file
#virsh restore /tmp/test/a
error: Failed to restore domain from /tmp/test/a
error: Failed to open file '/tmp/test/a': Not a directory

2 save the guest to the non-exist file
#virsh save rhel72 /tmp/test/a.rhel72
error: Failed to save domain rhel72 to /tmp/test/a.rhel72
error: Failed to create file '/tmp/test/a.rhel72': Not a directory

3.save the guest to the right file and the guest can be restored successfully
#virsh save rhel72 /tmp/rhel72.save
Domain rhel72 saved to /tmp/rhel72.save
# virsh restore /tmp/rhel72.save 
Domain restored from /tmp/rhel72.save

Since the bug report clear error message when restore domain from the non-exist file and the guest can be restored successfully from the normal saved file, so this bug was verifed

Comment 5 Ludek Smid 2014-06-13 12:22:44 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.