Bug 956075
Summary: | Define meaningful Expires for static css|ico files | ||
---|---|---|---|
Product: | [Retired] oVirt | Reporter: | Jiri Belka <jbelka> |
Component: | ovirt-engine-webadmin | Assignee: | Alexander Wels <awels> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | unspecified | CC: | acathrow, awels, ecohen, iheim, jbelka, jkt, mgoldboi, Rhev-m-bugs, talayan |
Target Milestone: | --- | ||
Target Release: | 3.4.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | ux | ||
Fixed In Version: | ovirt-3.4.0-alpha1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-03-31 12:26:06 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jiri Belka
2013-04-24 09:21:29 UTC
Alex - wasn't this one already taken care of? As far as I know we put expiration on everything. And as of Greg's favicon patch, the favicon doesn't exist in /favicon.ico anymore. Can we double check if Yslow is still reporting an E? (In reply to Alexander Wels from comment #2) > As far as I know we put expiration on everything. And as of Greg's favicon > patch, the favicon doesn't exist in /favicon.ico anymore. Can we double > check if Yslow is still reporting an E? Jiri? Sorry for delay but YSlow has stopped working on FF available on RHEL6. So FF 24.0 from Windows. Grade C on Add Expires headers There are 2 static components without a far-future expiration date. (2013/10/10) https://jb-rh33.rhev.lab.eng.brq.redhat.com/webadmin/webadmin/webadmin.nocache.js (no expires) https://jb-rh33.rhev.lab.eng.brq.redhat.com/webadmin/theme-resource/favicon - for webadmin.nocache.js I see now recent Expires. HTTP/1.1 304 Not Modified Date: Fri, 11 Oct 2013 10:46:30 GMT Connection: close Etag: W/"8824-1381246086000" Expires: Thu, 10 Oct 2013 10:46:30 GMT Cache-Control: no-cache Vary: Accept-Encoding Set-Cookie: locale=en_US; Expires=Wed, 29-Oct-2081 14:00:37 GMT; Path=/ - for favicon # type | size (KB) | url | expires | response time (ms) | etag favicon | 0.3K | https://jb-rh33.rhev.lab.eng.brq.redhat.com/webadmin/theme-resource/favicon | no expires | 85 | W/"318-1379968531000" This is a good example of why you shouldn't blindly follow whatever yslow says. webadmin.nocache.js should not be cached (hence the nocache) in the name. And thus it doesn't have an expires far in the future. On the other hand the favicon should have an expires which I will fix shortly. [clearing needinfo on me; please re-set it with a question if needed] oVirt 3.4.0 alpha has been released including the fix for this issue. ok, av2.1 rhevm-webadmin-portal-3.4.0-0.3.master.el6ev.noarch favicon expires 2015/3/11 and webadmin.nocache.js has short expire per reason. this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released |