Bug 889898
| Summary: | webadmin: yslow report on webadmin | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Yaniv Kaul <ykaul> |
| Component: | ovirt-engine-webadmin-portal | Assignee: | Alexander Wels <awels> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.1.1 | CC: | dyasny, ecohen, iheim, jkt, Rhev-m-bugs, sgrinber, ykaul |
| Target Milestone: | --- | Keywords: | Improvement |
| Target Release: | 3.2.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | ux | ||
| Fixed In Version: | sf12 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yaniv Kaul
2012-12-23 21:46:37 UTC
I also think previous work I've done on compressing the PNGs was lost when PNGs were re-done or something. very similar to bug 656954 (just on different components); there may be a single solution for both (depends on the level in which it is handled). (In reply to comment #1) > I also think previous work I've done on compressing the PNGs was lost when > PNGs were re-done or something. [this is about http://gerrit.ovirt.org/#/c/853/, I assume] AFAIU it wasn't lost - it is still there, in upstream (where it was done); simply need to do the same for the images downstream, that are different images. Yes same solution for both user portal and webadmin. Patches available here: http://gerrit.ovirt.org/#/c/10911/ and here for the expires headers: http://gerrit.ovirt.org/#/c/10449/ YSlow reports:
Grade E on Add Expires headers
There are 4 static components without a far-future expiration date.
(no expires) https://10.34.63.76/webadmin/webadmin/gwt/standard/standard.css
(no expires) https://10.34.63.76/webadmin/webadmin/WebAdmin.css
(2013/4/21) https://10.34.63.76/webadmin/webadmin/webadmin.nocache.js
(no expires) https://10.34.63.76/favicon.ico
webadmin.nocache.js is OK, <app>.nocache.js could be cached but browser always asks server if the contect hasn't been modified.
In BZ875814 there's no info if .css or .ico file(s) should have any expiration. Please clarify, right now those css files are cached but the server is asked if content has changed - 'no-cache' in Cache-Control, got 304 code when reloading. No idea how is favicon handled... ??
BZ875814 is about the dynamic content, not static content. The css and ico files are served from JBOSS. We assume that JBOSS knows how to properly send the headers to have the static content cached. I believe in this case it depends on an ETag instead of a future date for caching purposes. The favicon is served from Apache and I don't know how it handles caching in the case of a favicon. So I am not entirely sure what you are asking, but I believe the behavior you are seeing is correct for at least the webadmin.nocache.js (shouldn't be cached, and no future expire date). The two css files are okay due to the ETags. Not sure about the favicon. ok, sf13.1 - as clarified in comment#9 it is OK, it means 'no expires' is false alert from YSlow as there's ETag used anyway. But I created BZ956075 to make YSlow more happy. 3.2 has been released 3.2 has been released 3.2 has been released |