Bug 957466

Summary:	Review Request: perl-Test-FailWarnings - Add test failures if warnings are caught
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-FailWarnings-0.003-2.fc18	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-05-16 02:54:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2013-04-28 09:32:59 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings-0.003-1.fc18.src.rpm
Description:
This module hooks $SIG{__WARN__} and converts warnings to Test::More's
fail() calls. It is designed to be used with done_testing, when you don't
need to know the test count in advance.

Fedora Account System Username: eseyman

Builds in mock; rpmlint is silent.
This package is needed to update perl-Test-Type to the latest version.

Comment 1 Petr Šabata 2013-04-30 08:24:40 UTC

Your BRs are a bit chaotic, but correct.  Except for the "xt tests" block which is not needed as you don't run those tests at all.  These are generally used by the author only hence I'd advise removing this dep block rather than running that test suite.

This aside, the package looks good.

Comment 2 Emmanuel Seyman 2013-05-03 07:36:28 UTC

(In reply to comment #1)
> Except for the "xt tests" block which is not needed as you don't run those
> tests at all. These are generally used by the author only hence I'd advise
> removing this dep block rather than running that test suite.

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings-0.003-2.fc18.src.rpm

Comment 3 Petr Šabata 2013-05-03 08:44:00 UTC

Removed, approving.

Comment 4 Emmanuel Seyman 2013-05-03 11:26:18 UTC

Thanks, Petr. Requesting SCM

New Package SCM Request
=======================
Package Name: perl-Test-FailWarnings
Short Description: Add test failures if warnings are caught
Owners: eseyman
Branches: f18 f19
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-05-06 12:35:01 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-05-06 21:00:01 UTC

perl-Test-FailWarnings-0.003-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Test-FailWarnings-0.003-2.fc18

Comment 7 Fedora Update System 2013-05-07 18:34:46 UTC

perl-Test-FailWarnings-0.003-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-05-16 02:54:05 UTC

perl-Test-FailWarnings-0.003-2.fc18 has been pushed to the Fedora 18 stable repository.