Bug 957466 - Review Request: perl-Test-FailWarnings - Add test failures if warnings are caught
Summary: Review Request: perl-Test-FailWarnings - Add test failures if warnings are ca...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-28 09:32 UTC by Emmanuel Seyman
Modified: 2013-05-16 02:54 UTC (History)
3 users (show)

Fixed In Version: perl-Test-FailWarnings-0.003-2.fc18
Clone Of:
Environment:
Last Closed: 2013-05-16 02:54:05 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2013-04-28 09:32:59 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings-0.003-1.fc18.src.rpm
Description:
This module hooks $SIG{__WARN__} and converts warnings to Test::More's
fail() calls. It is designed to be used with done_testing, when you don't
need to know the test count in advance.

Fedora Account System Username: eseyman

Builds in mock; rpmlint is silent.
This package is needed to update perl-Test-Type to the latest version.

Comment 1 Petr Šabata 2013-04-30 08:24:40 UTC
Your BRs are a bit chaotic, but correct.  Except for the "xt tests" block which is not needed as you don't run those tests at all.  These are generally used by the author only hence I'd advise removing this dep block rather than running that test suite.

This aside, the package looks good.

Comment 2 Emmanuel Seyman 2013-05-03 07:36:28 UTC
(In reply to comment #1)
> Except for the "xt tests" block which is not needed as you don't run those
> tests at all. These are generally used by the author only hence I'd advise
> removing this dep block rather than running that test suite.

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-FailWarnings/perl-Test-FailWarnings-0.003-2.fc18.src.rpm

Comment 3 Petr Šabata 2013-05-03 08:44:00 UTC
Removed, approving.

Comment 4 Emmanuel Seyman 2013-05-03 11:26:18 UTC
Thanks, Petr. Requesting SCM

New Package SCM Request
=======================
Package Name: perl-Test-FailWarnings
Short Description: Add test failures if warnings are caught
Owners: eseyman
Branches: f18 f19
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-05-06 12:35:01 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-05-06 21:00:01 UTC
perl-Test-FailWarnings-0.003-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Test-FailWarnings-0.003-2.fc18

Comment 7 Fedora Update System 2013-05-07 18:34:46 UTC
perl-Test-FailWarnings-0.003-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-05-16 02:54:05 UTC
perl-Test-FailWarnings-0.003-2.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.