Bug 958093

Summary: gnome-color-manager: g_spawn_command_line_* misuse
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: gnome-color-managerAssignee: Richard Hughes <rhughes>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: rhughes
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-30 09:10:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 958080    

Description Florian Weimer 2013-04-30 11:32:53 UTC
gnome-color-manager invokes the g_spawn_command_line_* in various places, splicing file names into the command line string.  This doesn't work reliably if the file name contains spaces or other funny characters.

You should use g_spawn_sync or g_spawn_async, with an argument vector where the file name is passed separately.  You may have to include a "--" argument before the file name to suppress option processing.

Comment 1 Richard Hughes 2013-07-30 09:10:11 UTC
Again, not really a RHEL bug as we don't support calibration there due to the missing argyllcms. I have however committed this upstream for Fedora:

commit a8ee35723d20f966981b07454968109f1dd8455b
Author: Richard Hughes <richard>
Date:   Tue Jul 30 10:07:12 2013 +0100

    Do not use g_spawn_command_line_sync() when spawning executables
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=958093