Bug 958093 - gnome-color-manager: g_spawn_command_line_* misuse
Summary: gnome-color-manager: g_spawn_command_line_* misuse
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-color-manager
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 958080
TreeView+ depends on / blocked
 
Reported: 2013-04-30 11:32 UTC by Florian Weimer
Modified: 2013-07-30 09:10 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-30 09:10:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2013-04-30 11:32:53 UTC
gnome-color-manager invokes the g_spawn_command_line_* in various places, splicing file names into the command line string.  This doesn't work reliably if the file name contains spaces or other funny characters.

You should use g_spawn_sync or g_spawn_async, with an argument vector where the file name is passed separately.  You may have to include a "--" argument before the file name to suppress option processing.

Comment 1 Richard Hughes 2013-07-30 09:10:11 UTC
Again, not really a RHEL bug as we don't support calibration there due to the missing argyllcms. I have however committed this upstream for Fedora:

commit a8ee35723d20f966981b07454968109f1dd8455b
Author: Richard Hughes <richard>
Date:   Tue Jul 30 10:07:12 2013 +0100

    Do not use g_spawn_command_line_sync() when spawning executables
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=958093


Note You need to log in before you can comment on or make changes to this bug.