Bug 958108

Summary:	Fuse mount crashes while running FSCT tool on the Samba Share from a windows client
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	io-cache	Assignee:	Raghavendra G <rgowdapp>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	mainline	CC:	aavati, csaba, gluster-bugs, kaushal, mzywusko, rabhat, rhs-bugs, r-mccarthy, rwheeler, sdharane
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:	Cause: Some translators maintain state in each inode that is necessary for their functioning. This state is built during path to inode resolution. This resolution normally happens through LOOKUP operation. However, as an optimization READDIRP was introduced which acts as a batch lookup for all the directory entries being read. This code path didn't build translator state in inodes and hence these log messages were seen. Consequence: The translators wouldn't be able to function normally without state built in inodes. For eg., io-cache wouldn't cache file content if state is not present in inode. Fix: Code in Fuse-bridge makes sure that at-least one LOOKUP operation is done before proceeding with any file operation like OPEN, READ, WRITE etc., there by ensuring that translators would've built necessary state in inodes. Result: Log messages won't be seen and translators can do their intended function.	Story Points:	---
Clone Of:	953527	Environment:
Last Closed:	2015-05-15 17:10:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	953527
Bug Blocks:	994964

Comment 1 Anand Avati 2013-04-30 14:12:54 UTC

REVIEW: http://review.gluster.org/4916 (performance/io-cache: check the inode context to be NULL before accessing) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2013-05-01 16:54:39 UTC

COMMIT: http://review.gluster.org/4916 committed in master by Vijay Bellur (vbellur) 
------
commit b6e10801bee030fe7fcd1ec3bfac947ce44d023d
Author: Raghavendra Bhat <raghavendra>
Date:   Tue Apr 30 19:41:34 2013 +0530

    performance/io-cache: check the inode context to be NULL before accessing
    
    Change-Id: I475af7f8ffd5e5d8adbd2a74af20e56ad7751f69
    BUG: 958108
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/4916
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Anand Avati 2013-05-17 07:26:58 UTC

REVIEW: http://review.gluster.org/5029 (performance/io-cache: update inode contexts of each entry in readdir) posted (#1) for review on master by Raghavendra G (raghavendra)

Comment 4 Anand Avati 2013-05-17 09:05:07 UTC

REVIEW: http://review.gluster.org/5029 (performance/io-cache: update inode contexts of each entry in readdir) posted (#2) for review on master by Raghavendra G (raghavendra)

Comment 5 Anand Avati 2013-05-23 17:49:08 UTC

REVIEW: http://review.gluster.org/5077 (performance/io-cache: check the inode context to be NULL before accessing) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 6 Anand Avati 2013-05-23 20:04:39 UTC

COMMIT: http://review.gluster.org/5077 committed in release-3.4 by Anand Avati (avati) 
------
commit df83bc05ff2c09fe5bd12ae32398bc58471d1f1a
Author: Raghavendra Bhat <raghavendra>
Date:   Tue Apr 30 19:41:34 2013 +0530

    performance/io-cache: check the inode context to be NULL before accessing
    
    Change-Id: I475af7f8ffd5e5d8adbd2a74af20e56ad7751f69
    BUG: 958108
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/4916
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/5077
    Reviewed-by: Anand Avati <avati>

Comment 7 santosh pradhan 2013-05-30 05:50:35 UTC

*** Bug 967031 has been marked as a duplicate of this bug. ***

Comment 8 Anand Avati 2013-09-11 04:09:48 UTC

REVIEW: http://review.gluster.org/5029 (performance/io-cache: update inode contexts of each entry in readdir) posted (#3) for review on master by Raghavendra G (rgowdapp)

Comment 9 Raghavendra G 2014-01-15 06:12:54 UTC

http://review.gluster.org/#/c/5267/ fixes the issue.

Comment 10 Niels de Vos 2015-05-15 17:10:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Worker Ant 2017-07-18 17:15:59 UTC

REVIEW: https://review.gluster.org/5029 (performance/io-cache: update inode contexts of each entry in readdir) posted (#4) for review on master by Raghavendra G (rgowdapp)