Bug 959188

Summary:	Review Request: perl-Plack-Middleware-Deflater - Compress response body with Gzip or Deflate
Product:	[Fedora] Fedora	Reporter:	Robin Lee <robinlee.sysu>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Plack-Middleware-Deflater-0.08-2.fc17	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-05-25 12:11:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	957622

Description Robin Lee 2013-05-03 10:14:43 UTC

Spec URL: http://cheeselee.fedorapeople.org/perl-Plack-Middleware-Deflater.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Plack-Middleware-Deflater-0.08-1.fc18.src.rpm
Description:
Plack::Middleware::Deflater is a middleware to encode your response body in
gzip or deflate, based on Accept-Encoding HTTP request header. It would
save the bandwidth a little bit but should increase the Plack server load,
so ideally you should handle this on the frontend reverse proxy servers.

Fedora Account System Username: cheeselee

Comment 1 Petr Šabata 2013-05-14 15:17:55 UTC

There are some dependency issues again :)

First, required in lib/:
 - parent
 - Plack::Middleware
 - Plack::Util
 - Plack::Util::Accessor

Second, forgotten deps from inc/Module/Install/:
 - File::Spec
 - Spiffy *
 - Test::Base::Filter *
 - Test::Builder *
 - Test::Builder::Module *

* - those seem to be loaded via Makefile.PL's use_test_base() call in inc/Module/Install/TestBase.pm


And you could also substitute PERL_INSTALL_ROOT with DESTDIR.

Also consider alternative spelling of 'frontend':
perl-Plack-Middleware-Deflater.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end

Comment 2 Robin Lee 2013-05-15 02:45:55 UTC

Changes:
- BuildRequires more Perl modules: parent, Plack::Middleware, Plack::Util,
  Plack::Util::Accessor, File::Spec, Spiffy, Test::Base::Filter,
  Test::Builder, Test::Builder::Module
- 'frontend' changed to 'front end'

Spec URL: http://cheeselee.fedorapeople.org/perl-Plack-Middleware-Deflater.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Plack-Middleware-Deflater-0.08-2.fc18.src.rpm

Comment 3 Petr Šabata 2013-05-15 09:27:57 UTC

Great, approving.

Comment 4 Robin Lee 2013-05-15 14:47:22 UTC

New Package SCM Request
=======================
Package Name: perl-Plack-Middleware-Deflater
Short Description: Compress response body with Gzip or Deflate
Owners: cheeselee
Branches: f17 f18 f19
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-05-15 15:02:52 UTC

Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-05-16 06:05:45 UTC

perl-Plack-Middleware-Deflater-0.08-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Plack-Middleware-Deflater-0.08-2.fc17

Comment 7 Fedora Update System 2013-05-17 03:27:46 UTC

perl-Plack-Middleware-Deflater-0.08-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 8 Fedora Update System 2013-05-25 12:11:56 UTC

perl-Plack-Middleware-Deflater-0.08-2.fc17 has been pushed to the Fedora 17 stable repository.