Bug 957622 - Review Request: perl-Twiggy - AnyEvent HTTP server for PSGI (like Thin)
Summary: Review Request: perl-Twiggy - AnyEvent HTTP server for PSGI (like Thin)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 959188
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-04-29 07:25 UTC by Robin Lee
Modified: 2013-06-20 02:33 UTC (History)
3 users (show)

Fixed In Version: perl-Twiggy-0.1021-3.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-20 02:33:43 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Robin Lee 2013-04-29 07:25:57 UTC
Spec URL: http://cheeselee.fedorapeople.org/perl-Twiggy.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Twiggy-0.1021-1.fc18.src.rpm
Description: Twiggy is a lightweight and fast HTTP server based on AnyEvent and can run any PSGI applications.
Fedora Account System Username: cheeselee

Comment 1 Petr Šabata 2013-05-02 14:26:44 UTC
The package uses bundled inc::Module::Install, either buildrequire all its actual dependencies (preferred, listed below) or buildrequire perl(inc::Module::Install) and delete tne inc directory.

perl(base)
perl(Carp)
perl(Config)
perl(Cwd)
perl(ExtUtils::MM_Unix)
perl(Fcntl)
perl(File::Find)
perl(File::Path)
perl(FindBin)
perl(Pod::Text)
perl(strict)
perl(vars)

In addition to those, you're missing many other used in Twiggy code and/or the test suite (some are shared with inc::Module::Install):

perl(AnyEvent::AIO)
perl(AnyEvent::Handle)
perl(AnyEvent::Socket)
perl(AnyEvent::Util)
perl(base)
perl(Carp)
perl(constant)
perl(Errno)
perl(FindBin)
perl(HTTP::Request)
perl(HTTP::Request::Common)
perl(HTTP::Response)
perl(IO::AIO)
perl(IO::Handle)
perl(IO::Socket::INET)
perl(IO::Uncompress::Gunzip)
perl(LWP::UserAgent)
perl(parent)
perl(Plack::App::File)
perl(Plack::HTTPParser)
perl(Plack::Loader)
perl(Plack::Request)
perl(Plack::Test::Suite)
perl(Plack::Util)
perl(Scalar::Util)
perl(Socket)
perl(warnings)

Consider packaging Plack::Middleware::Deflater too, so the deflater.t tests get executed.

You can drop perl(HTTP::Status) and perl(Try::Tiny) from your runtime dep list.  RPM finds those automatically.  perl(AnyEvent::AIO) and perl(IO::AIO), on the other hand, don't get auto-detected and you need to require them explicitly.

Oh, and perhaps some users would find the examples in the 'eg' directory useful?...

Comment 2 Robin Lee 2013-05-03 10:17:52 UTC
Changes:
- Revise BuildRequires and Requires
- Include the eg directory to %%doc

Spec URL: http://cheeselee.fedorapeople.org/perl-Twiggy.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Twiggy-0.1021-2.fc18.src.rpm

I also submitted a review request for Plack::Middleware::Deflater.

Comment 3 Petr Šabata 2013-05-03 10:34:03 UTC
Alright, better.
You have some duplicate BRs now, though.

I'm going to review Plack::Middleware::Deflater too...

Comment 4 Robin Lee 2013-05-03 11:46:57 UTC
Thanks!

Change:
- Remove duplicated BR

Spec URL: http://cheeselee.fedorapeople.org/perl-Twiggy.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Twiggy-0.1021-3.fc18.src.rpm

Comment 5 Petr Šabata 2013-05-15 10:54:39 UTC
Ok, spec clean, Plack::Middleware::Deflater review done -- time to approve this too :)

Comment 6 Robin Lee 2013-05-15 14:47:12 UTC
New Package SCM Request
=======================
Package Name: perl-Twiggy
Short Description: AnyEvent HTTP server for PSGI (like Thin)
Owners: cheeselee
Branches: f17 f18 f19
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2013-05-15 15:00:19 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2013-05-27 03:34:13 UTC
perl-Twiggy-0.1021-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Twiggy-0.1021-3.fc17

Comment 9 Fedora Update System 2013-05-28 01:01:28 UTC
perl-Twiggy-0.1021-3.fc17 has been pushed to the Fedora 17 testing repository.

Comment 10 Fedora Update System 2013-06-20 02:33:43 UTC
perl-Twiggy-0.1021-3.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.