Spec URL: http://cheeselee.fedorapeople.org/perl-Twiggy.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Twiggy-0.1021-1.fc18.src.rpm Description: Twiggy is a lightweight and fast HTTP server based on AnyEvent and can run any PSGI applications. Fedora Account System Username: cheeselee
The package uses bundled inc::Module::Install, either buildrequire all its actual dependencies (preferred, listed below) or buildrequire perl(inc::Module::Install) and delete tne inc directory. perl(base) perl(Carp) perl(Config) perl(Cwd) perl(ExtUtils::MM_Unix) perl(Fcntl) perl(File::Find) perl(File::Path) perl(FindBin) perl(Pod::Text) perl(strict) perl(vars) In addition to those, you're missing many other used in Twiggy code and/or the test suite (some are shared with inc::Module::Install): perl(AnyEvent::AIO) perl(AnyEvent::Handle) perl(AnyEvent::Socket) perl(AnyEvent::Util) perl(base) perl(Carp) perl(constant) perl(Errno) perl(FindBin) perl(HTTP::Request) perl(HTTP::Request::Common) perl(HTTP::Response) perl(IO::AIO) perl(IO::Handle) perl(IO::Socket::INET) perl(IO::Uncompress::Gunzip) perl(LWP::UserAgent) perl(parent) perl(Plack::App::File) perl(Plack::HTTPParser) perl(Plack::Loader) perl(Plack::Request) perl(Plack::Test::Suite) perl(Plack::Util) perl(Scalar::Util) perl(Socket) perl(warnings) Consider packaging Plack::Middleware::Deflater too, so the deflater.t tests get executed. You can drop perl(HTTP::Status) and perl(Try::Tiny) from your runtime dep list. RPM finds those automatically. perl(AnyEvent::AIO) and perl(IO::AIO), on the other hand, don't get auto-detected and you need to require them explicitly. Oh, and perhaps some users would find the examples in the 'eg' directory useful?...
Changes: - Revise BuildRequires and Requires - Include the eg directory to %%doc Spec URL: http://cheeselee.fedorapeople.org/perl-Twiggy.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Twiggy-0.1021-2.fc18.src.rpm I also submitted a review request for Plack::Middleware::Deflater.
Alright, better. You have some duplicate BRs now, though. I'm going to review Plack::Middleware::Deflater too...
Thanks! Change: - Remove duplicated BR Spec URL: http://cheeselee.fedorapeople.org/perl-Twiggy.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Twiggy-0.1021-3.fc18.src.rpm
Ok, spec clean, Plack::Middleware::Deflater review done -- time to approve this too :)
New Package SCM Request ======================= Package Name: perl-Twiggy Short Description: AnyEvent HTTP server for PSGI (like Thin) Owners: cheeselee Branches: f17 f18 f19 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Twiggy-0.1021-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Twiggy-0.1021-3.fc17
perl-Twiggy-0.1021-3.fc17 has been pushed to the Fedora 17 testing repository.
perl-Twiggy-0.1021-3.fc17 has been pushed to the Fedora 17 stable repository.