Bug 959570

Summary: Comma replacement bug in Subscription field on My Installed Products tab
Product: Red Hat Enterprise Linux 5 Reporter: Matt Reid <mreid>
Component: subscription-managerAssignee: Bryan Kearney <bkearney>
Status: CLOSED ERRATA QA Contact: IDM QE LIST <seceng-idm-qe-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.10CC: bkearney, fsharath, jesusr, jgalipea
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
No description necessary
 Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-30 23:07:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 840995    
Attachments:
Description Flags
Comma replaced with and
none
Comma showing correctly on My Subscriptions tab
none
Comma separated Suscriptions none

Description Matt Reid 2013-05-03 20:05:46 UTC 
Description of problem:
Using sub-man 1.8.6-1.git.27.f8647f0 I'm seeing the Subscription name we stick in the Details table on the My Installed Products tab get the comma swapped out for an 'and', so that the Subscription name (in this case) shows as "Red Hat Enterprise Linux Developer Support and Professional", whereas it shows as "Red Hat Enterprise Linux Developer Support, Professional" on our other tabs.

Is this a hold over from the Properly Subscribed string if they're covered by multiple contracts? That's the only place I can think of off the top of my head where we might want to pull commas and put in ands. It'd be nice if we were smart enough to not replace commas that shouldn't be replaced. 

Version-Release number of selected component (if applicable):
sub-man 1.8.6-1.git.27.f8647f0

How reproducible:
100%

Steps to Reproduce:
1. Attach a subscription with a comma in the Subscription name
2. Look at the corresponding product in the My Installed Products tab and look at the Subscription name

  
Actual results:
Subscription is listed as "Red Hat Enterprise Linux Developer Support and Professional"

Expected results:
Subscription should be listed as "Red Hat Enterprise Linux Developer Support, Professional"

Additional info:
Comment 1 Matt Reid 2013-05-03 20:09:27 UTC 
Created attachment 743371 [details]
Comma replaced with and
Comment 2 Matt Reid 2013-05-03 20:10:30 UTC 
Created attachment 743372 [details]
Comma showing correctly on My Subscriptions tab
Comment 3 RHEL Program Management 2013-05-03 20:27:48 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux release.  Product Management has
requested further review of this request by Red Hat Engineering, for
potential inclusion in a Red Hat Enterprise Linux release for currently
deployed products.  This request is not yet committed for inclusion in
a release.
Comment 4 Bryan Kearney 2013-05-07 20:34:42 UTC 
https://github.com/candlepin/subscription-manager/pull/586
Comment 5 Bryan Kearney 2013-05-08 15:10:33 UTC 
commit b00496112a2d15095ddfc58e750d4a51c4936e99
Author: Bryan Kearney <bkearney>
Date:   Tue May 7 16:32:16 2013 -0400

    959570: Subscription names were being mangled in the installed products page.
    
    This was due to the name concatination logic which replaced he last comma
    with the word "and". This worked fine unless the subscription as a comma in it.
Comment 7 Sharath Dwaral 2013-05-22 15:24:19 UTC 
Created attachment 751749 [details]
Comma separated Suscriptions

Version: Brew Build

# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: Unknown
subscription-manager: 1.8.8-1.el5
python-rhsm: 1.8.11-1.el5_9


Tested against Stage

Please see attachment

VERIFIED
Comment 9 errata-xmlrpc 2013-09-30 23:07:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1332.html