Bug 960064
| Summary: | Review Request: rubygem-lumberjack - A fast logging utility | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedoraparked |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, jar.prokop, jstribny, package-review, vondruch |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0.12-1.fc28 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-10 17:30:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 960061 | ||
|
Description
fedoraparked
2013-05-06 14:12:09 UTC
Additionally, mock builds: http://anujmore.fedorapeople.org/pkgs/rubygem-lumberjack/mock-lumberjack-build.log http://anujmore.fedorapeople.org/pkgs/rubygem-lumberjack/mock-lumberjack-screen.txt rpmlint gives this: rubygem-lumberjack.noarch: W: no-documentation rubygem-lumberjack.src:49: W: macro-in-comment %gem_dir 3 packages and 0 specfiles checked; 0 errors, 2 warnings. I will take it for a review. * Move MIT_LICENSE file into the main package * Requiring rspec-core seems to be redundant since you are already requiring the whole rspec Otherwise the spec looks good, rpmlint doesn't complain and the package builds and runs. Please update the spec file accordingly so I can approve. BTW the %{gem_instdir}/MIT_LICENSE should be marked by %doc macro.
And I have one additional note, Anuj have you verified that the gem works well without the VERSION file? It is sometime needed, so I am just asking, have not tested it myself in this particular case.
Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-lumberjack/rubygem-lumberjack.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-lumberjack/rubygem-lumberjack-1.0.3-2.fc19.src.rpm Did as you asked. Also, the macro in a comment has been fixed. mock builds just fine. rpmlint doesn't complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. @vondruch: How do I verify that? Actually write a small program the uses the gem? Anuj, you don't need to write programs to check it. Vit raised the issue because some gems allow you to get the version of the gem while running them e.g. something like `SomeGem::VERSION` and this could require the VERSION file, because it's the only place where the version is saved. What you need to check is therefore where and how the file is used in the source code. Nevertheless I already check that for you - this file is needed only for .gemspec file that is used when building a new gem before releasing it. And this file is not a part of a distributed .gem package. Apart from that, your srpm builds fine both in koji[1] and mock, installs and runs without any issues so I am APPROVING this package. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5360352 New Package SCM Request ======================= Package Name: rubygem-lumberjack Short Description: A simple, powerful, and very fast logging utility that can be a drop in replacement for Logger or ActiveSupport::BufferedLogger. Owners: anujmore axilleas Branches: f18 f19 Git done (by process-git-requests). Hi guys, the repository was created, but the package itself was never imported. Could you please import the package? Anuj assigned me as admin. I have imported and built the package. Thank you guys! |