Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-guard/rubygem-guard.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-guard/rubygem-guard-1.8.0-1.fc19.src.rpm Description: Guard is a command line tool to easily handle events on file system modifications. Fedora Account System Username: anujmore
Additionally, mock builds: http://anujmore.fedorapeople.org/pkgs/rubygem-guard/mock-guard-build.log http://anujmore.fedorapeople.org/pkgs/rubygem-guard/mock-guard-screen.txt rpmlint gives this: rubygem-guard.noarch: W: no-manual-page-for-binary guard rubygem-guard.src:50: W: macro-in-comment %gem_dir 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
I will take it for a review.
* dependencies rubygem-listen > 1.0.0 is not yet packaged for Fedora [1], I added corresponding "depends on" * licensing LICENSE file should be included in the main package * %doc README.md and CHANGELOG.md could be marked as %doc * man pages /man doesn't contain any executables so the content shouldn't be in the main package. I also think that since man page is included, it should be installed to a system man path so the user can really type "man guard" to see the manual. I suggest installing the man page as %{_mandir}/man1/guard.1 to %{buildroot} and put the .html version to the %doc subpackage. [1] https://bugzilla.redhat.com/show_bug.cgi?id=853781
And I forgot: * tests Please run the test suite [1] in %check [1] https://github.com/guard/guard/tree/master/spec
The rubygem-listen was updated recently, so this review could continue.
*** Bug 1268694 has been marked as a duplicate of this bug. ***
Hi Ilya, are you going to take over this review?