Bug 961384
| Summary: | Review Request: vim-javabrowser - JavaBrowser plugin for VIM | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Hracek <phracek> |
| Component: | Package Review | Assignee: | Robert Kuska <rkuska> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jberan, notting, package-review, rkuska, sochotni |
| Target Milestone: | --- | Flags: | rkuska:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | vim-javabrowser-2.03-3.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-07-15 14:41:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Hracek
2013-05-09 14:05:53 UTC
Not doing a full review, just a few comments: * missing description * Group tag is not really used/needed anymore * Why do you need Requires(post[un]): vim? There are no post[un] scriptlets * %defattr macro is not needed either Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-2.fc18.src.rpm Issues where fixed I'll take this for a review. You forgot to remove %defattr macro. Thanks, %defattr macro was removed: Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-3.fc18.src.rpm ~/work/JavaBrowser> rpmlint /home/phracek/rpmbuild/RPMS/noarch/vim-javabrowser-2.03-3.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ~/work/JavaBrowser> rpmlint /home/phracek/rpmbuild/SRPMS/vim-javabrowser-2.03-3.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ~/work/JavaBrowser> The requested URL /vim-javabrowser/vim-javabrowser-2.03-3.fc18.src.rpm was not found on this server. Please fix that so I can use fedora-review tool. I upgraded OS to Fedora 19. Correct URLs are: Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-3.fc19.src.rpm Copy paste error:( Looks good now, approved. New Package SCM Request ======================= Package Name: vim-javabrowser Short Description: JavaBrowser plugin for VIM Owners: phracek Branches: f19 Git done (by process-git-requests). scm-commit (https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130715/1056572.html) -> CLOSED RAWHIDE vim-javabrowser-2.03-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/vim-javabrowser-2.03-3.fc19 vim-javabrowser-2.03-3.fc19 has been pushed to the Fedora 19 stable repository. |