Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-1.fc18.src.rpm Description: This script is SPECIFICALLY tailored for Java language. So, it shows structure of the Java file starting with classes defined within it and NOT in a general tag structure. I found it useful and hope you all find it useful too. It also has a nice syntax to show the class members in UML format. Fedora Account System Username: phracek $ rpmlint vim-javabrowser.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/phracek/rpmbuild/SRPMS/vim-javabrowser-2.03-1.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $
Not doing a full review, just a few comments: * missing description * Group tag is not really used/needed anymore * Why do you need Requires(post[un]): vim? There are no post[un] scriptlets * %defattr macro is not needed either
Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-2.fc18.src.rpm Issues where fixed
I'll take this for a review.
You forgot to remove %defattr macro.
Thanks, %defattr macro was removed: Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-3.fc18.src.rpm ~/work/JavaBrowser> rpmlint /home/phracek/rpmbuild/RPMS/noarch/vim-javabrowser-2.03-3.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ~/work/JavaBrowser> rpmlint /home/phracek/rpmbuild/SRPMS/vim-javabrowser-2.03-3.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ~/work/JavaBrowser>
The requested URL /vim-javabrowser/vim-javabrowser-2.03-3.fc18.src.rpm was not found on this server. Please fix that so I can use fedora-review tool.
I upgraded OS to Fedora 19. Correct URLs are: Spec URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser.spec SRPM URL: http://phracek.fedorapeople.org/vim-javabrowser/vim-javabrowser-2.03-3.fc19.src.rpm Copy paste error:(
Looks good now, approved.
New Package SCM Request ======================= Package Name: vim-javabrowser Short Description: JavaBrowser plugin for VIM Owners: phracek Branches: f19
Git done (by process-git-requests).
scm-commit (https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130715/1056572.html) -> CLOSED RAWHIDE
vim-javabrowser-2.03-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/vim-javabrowser-2.03-3.fc19
vim-javabrowser-2.03-3.fc19 has been pushed to the Fedora 19 stable repository.