Bug 963077
| Summary: | Review Request: brise - The official Rime schema repository | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peng Wu <pwu> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i18n-bugs, i, notting, package-review |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ibus-rime-0.9.9-2.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-28 00:59:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 963074 | ||
| Bug Blocks: | 963078 | ||
|
Description
Peng Wu
2013-05-15 06:05:42 UTC
librime is built for rawhide. Please review this package, thanks. Just a note, Summary: "T"he Why: #Requires: librime ? :) Review: + mock build succeeded for rawhide + rpmlint on rpms gave brise.src: W: summary-not-capitalized C the official Rime schema repository brise.src: W: invalid-url Source0: http://rimeime.googlecode.com/files/brise-0.22.tar.gz HTTP Error 404: Not Found brise.x86_64: W: summary-not-capitalized C the official Rime schema repository brise.x86_64: E: no-binary brise-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 3 warnings. ==> sourcecode warning can be ignored here + Source verified with upstream as http://rimeime.googlecode.com/files/brise-0.22.tar.gz : CHECKSUM(SHA256) this package : a048b741a7651dbb47d1b6e6e25d266d670680112b70ca3c27f2bc17dcafde59 CHECKSUM(SHA256) upstream package : a048b741a7651dbb47d1b6e6e25d266d670680112b70ca3c27f2bc17dcafde59 + package follows packaging guidelines Suggestions: 1) Should this be noarch package? if not then you can disable debuginfo package with "%global debug_package %{nil}" at the beginning of the spec. 2) Please fix the issues raised in above comments. 3) you can also ChangeLog AUTHORS add to %doc Fixed, please review it again. Spec URL: http://pwu.fedorapeople.org/rime/brise.spec SRPM URL: http://pwu.fedorapeople.org/rime/brise-0.22-2.fc18.src.rpm Looks good now. Thanks. Once this become available in f20 tree, will check for ibus-rime review. APPROVED. New Package SCM Request ======================= Package Name: brise Short Description: The official Rime schema repository Owners: pwu Branches: f18 f19 InitialCC: i18n-team petersen Git done (by process-git-requests). ibus-rime-0.9.9-2.fc18,brise-0.22-2.fc18,librime-0.9.8-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ibus-rime-0.9.9-2.fc18,brise-0.22-2.fc18,librime-0.9.8-2.fc18 ibus-rime-0.9.9-2.fc19,brise-0.22-2.fc19,librime-0.9.8-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ibus-rime-0.9.9-2.fc19,brise-0.22-2.fc19,librime-0.9.8-2.fc19 ibus-rime-0.9.9-2.fc19, brise-0.22-2.fc19, librime-0.9.8-2.fc19 has been pushed to the Fedora 19 testing repository. ibus-rime-0.9.9-2.fc18, brise-0.22-2.fc18, librime-0.9.8-2.fc18 has been pushed to the Fedora 18 stable repository. ibus-rime-0.9.9-2.fc19, brise-0.22-2.fc19, librime-0.9.8-2.fc19 has been pushed to the Fedora 19 stable repository. |