Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://pwu.fedorapeople.org/rime/ibus-rime.spec SRPM URL: http://pwu.fedorapeople.org/rime/ibus-rime-0.9.9-1.fc18.src.rpm Description: ibus-rime: Rime Input Method Engine for Linux/IBus Fedora Account System Username:pwu
Please mention in the summary/description what this engine is for. The current --- Summary: Rime Input Method Engine for Linux/IBus %description ibus-rime: Rime Input Method Engine for Linux/IBus ---- does not really explain what it is... I would be good to include zh translations of the Summary and Description too. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#summary
Review: + mock build succeeded for rawhide + rpmlint on rpms gave ibus-rime.src: W: invalid-url Source0: http://rimeime.googlecode.com/files/ibus-rime-0.9.9.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 1 warnings. + Source verified with upstream as http://rimeime.googlecode.com/files/ibus-rime-0.9.9.tar.gz : CHECKSUM(SHA256) this package : 5bbb76abc763bdd3c83a5fe594f1488b34377b34b3f6e3c8c7b5cf86ab550cad CHECKSUM(SHA256) upstream package : 5bbb76abc763bdd3c83a5fe594f1488b34377b34b3f6e3c8c7b5cf86ab550cad suggestions: 1) remove unnecessary comments from spec 2) fix the issue raised in comment#1 3) Add ChangeLog to %doc
Fixed, please review it again, thanks. Spec URL: http://pwu.fedorapeople.org/rime/ibus-rime.spec SRPM URL: http://pwu.fedorapeople.org/rime/ibus-rime-0.9.9-2.fc18.src.rpm
only thing remaining is to own the directory /usr/share/ibus-rime/ and /usr/share/ibus-rime/icons you can simply write in %files which owns both directories %{_datadir}/ibus-rime/ APPROVED.
Okay, I will fix it when importing.
New Package SCM Request ======================= Package Name: ibus-rime Short Description: Rime Input Method Engine for IBus Owners: pwu Branches: f18 f19 InitialCC: i18n-team petersen
Git done (by process-git-requests).
ibus-rime-0.9.9-2.fc18,brise-0.22-2.fc18,librime-0.9.8-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ibus-rime-0.9.9-2.fc18,brise-0.22-2.fc18,librime-0.9.8-2.fc18
ibus-rime-0.9.9-2.fc19,brise-0.22-2.fc19,librime-0.9.8-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ibus-rime-0.9.9-2.fc19,brise-0.22-2.fc19,librime-0.9.8-2.fc19
ibus-rime-0.9.9-2.fc19, brise-0.22-2.fc19, librime-0.9.8-2.fc19 has been pushed to the Fedora 19 testing repository.
ibus-rime-0.9.9-2.fc18, brise-0.22-2.fc18, librime-0.9.8-2.fc18 has been pushed to the Fedora 18 stable repository.
ibus-rime-0.9.9-2.fc19, brise-0.22-2.fc19, librime-0.9.8-2.fc19 has been pushed to the Fedora 19 stable repository.