Bug 963211

Summary: Review Request: perl-Time-Mock - Replaces actual time with simulated time - alternative to Test::MockTime
Product: [Fedora] Fedora Reporter: Yanko Kaneti <yaneti>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, psabata
Target Milestone: ---Flags: psabata: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-17 18:06:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 963213    

Description Yanko Kaneti 2013-05-15 12:08:41 UTC 
Spec URL: http://declera.com/~yaneti/perl-Time-Mock/perl-Time-Mock.spec
SRPM URL: http://declera.com/~yaneti/perl-Time-Mock/perl-Time-Mock-0.0.2-1.fc20.src.rpm
Description: Replaces actual time with simulated time - alternative to Test::MockTime
Fedora Account System Username: yaneti

perl-Time-Mock.noarch: W: spelling-error Summary(en_US) MockTime -> Mock Time, Mock-time, Mortimer
perl-Time-Mock.noarch: W: spelling-error %description -l en_US MockTime -> Mock Time, Mock-time, Mortimer
perl-Time-Mock.noarch: W: spelling-error %description -l en_US timestep -> time step, time-step, estimate
perl-Time-Mock.noarch: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies
perl-Time-Mock.src: W: spelling-error Summary(en_US) MockTime -> Mock Time, Mock-time, Mortimer
perl-Time-Mock.src: W: spelling-error %description -l en_US MockTime -> Mock Time, Mock-time, Mortimer
perl-Time-Mock.src: W: spelling-error %description -l en_US timestep -> time step, time-step, estimate
perl-Time-Mock.src: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Comment 1 Petr Šabata 2013-05-16 13:05:07 UTC 
Missing build-time deps:
 - perl(Carp)
 - Recommended: perl(strict), perl(version), perl(warnings)

Line 33 is not necessary.

Consider correcting the 'timestep' spelling as suggested by rpmlint.

No other issues.
Comment 2 Yanko Kaneti 2013-05-16 21:09:23 UTC 
Thanks for the review. New spec should fix all those issues.

0.0.2-2
- Address review comments. (#963211#c1)

Spec URL: http://declera.com/~yaneti/perl-Time-Mock/perl-Time-Mock.spec
SRPM URL: http://declera.com/~yaneti/perl-Time-Mock/perl-Time-Mock-0.0.2-2.fc20.src.rpm
Comment 3 Petr Šabata 2013-05-17 13:34:26 UTC 
Ok, looks good.
Approving.
Comment 4 Yanko Kaneti 2013-05-17 14:26:27 UTC 
New Package SCM Request
=======================
Package Name: perl-Time-Mock
Short Description: Replaces actual time with simulated time - alternative to Test::MockTime
Owners: yaneti
Branches: f19 el6
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2013-05-17 17:11:01 UTC 
Git done (by process-git-requests).
Comment 6 Yanko Kaneti 2013-05-17 18:06:06 UTC 
Built for rawhide, f19 and el6. Bodhi updates for f19 and el6 submitted.

Closing. Thanks all.