Bug 963213 - Review Request: perl-HTTP-CookieJar - Minimalist HTTP user agent cookie jar
Summary: Review Request: perl-HTTP-CookieJar - Minimalist HTTP user agent cookie jar
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 963197 963211
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-15 12:16 UTC by Yanko Kaneti
Modified: 2013-05-28 06:24 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-05-28 06:24:40 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Yanko Kaneti 2013-05-15 12:16:29 UTC
Spec URL: http://declera.com/~yaneti/perl-HTTP-CookieJar/perl-HTTP-CookieJar.spec
SRPM URL: http://declera.com/~yaneti/perl-HTTP-CookieJar/perl-HTTP-CookieJar-0.004-1.fc20.src.rpm
Description: Minimalist HTTP user agent cookie jar
Fedora Account System Username: yaneti

Depends on the reviews I'll link below so no build in mock yet

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Petr Šabata 2013-05-16 13:33:21 UTC
Missing build-time deps:
- Recommended: perl(File::Find), perl(HTTP::Request)*, perl(HTTP::Response)*, perl(strict), perl(warnings)
* If you don't include those, you may safely drop some others that depend on them, e.g. perl(URI).

None of your explicit run-requires are necessary and should be dropped.  RPM detects all of them but Mozilla::PublicSuffix, which is optional.

PERL_INSTALL_ROOT could be substituted with DESTDIR.

Line 48 may be removed.

There's no need to ship dist.ini, META.json, perlcritic.rc, or tidyall.ini as %doc.

I'll try to build it once our dependencies make it into Fedora.

Comment 2 Yanko Kaneti 2013-05-17 18:16:15 UTC
Thanks for the review. I tried addressing all the issues in

0.004-2
- Address review comments. (#963213#c1)

Spec URL: http://declera.com/~yaneti/perl-HTTP-CookieJar/perl-HTTP-CookieJar.spec
SRPM URL: http://declera.com/~yaneti/perl-HTTP-CookieJar/perl-HTTP-CookieJar-0.004-2.fc20.src.rpm

Comment 3 Petr Šabata 2013-05-20 14:04:40 UTC
Alright, all fixed.
Approving.

Comment 4 Yanko Kaneti 2013-05-20 14:14:17 UTC
New Package SCM Request
=======================
Package Name: perl-HTTP-CookieJar
Short Description: Minimalist HTTP user agent cookie jar
Owners: yaneti
Branches: f19
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-05-20 14:27:08 UTC
Git done (by process-git-requests).

Comment 6 Yanko Kaneti 2013-05-28 06:24:40 UTC
Deps in stable. Builds done. Updates submitted.
Thanks.


Note You need to log in before you can comment on or make changes to this bug.