Bug 963448

Summary:	Incorrect exception handling in CoreGroupCommunicationService#handle
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	dereed
Component:	Clustering	Assignee:	Paul Ferraro <paul.ferraro>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jitka Kozana <jkudrnac>
Severity:	medium	Docs Contact:	Russell Dickenson <rdickens>
Priority:	unspecified
Version:	6.0.1	CC:	jkudrnac, kkhan, myarboro, paul.ferraro, rhusar, rjanik, sgilda, smumford
Target Milestone:	DR0
Target Release:	EAP 6.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	In previous versions of JBoss EAP 6, it was found that `CoreGroupCommunicationService#handle` was mishandling exceptions, affecting caller of the class. The class was found to be hiding exceptions and returning `null` values instead. This value could produce unexpected and unintended behaviors in callers. In this release, the null response will be dealt with by the distributed lock manager, however the use of `CommandDispatcher` in future releases of the product will resolve the issue permanently.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-28 15:31:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description dereed 2013-05-15 20:03:52 UTC

org/jboss/as/clustering/impl/CoreGroupCommunicationService#handle catches and hides any internal exceptions, and just returns null instead.

This breaks callers of CoreGroupCommunicationService when they get a null value where it's not expected (after verifying that the response was not flagged as an exception)

java.lang.NullPointerException
at org.jboss.as.clustering.lock.AbstractClusterLockSupport.lock(AbstractClusterLockSupport.java:157)

It also catches an exception from the called method, and returns it as the return value, instead of just throwing it as an exception so it can be properly returned as an exception inside JGroups' RequestCorrelator.

Comment 2 JBoss JIRA Server 2013-07-25 18:57:22 UTC

Paul Ferraro <paul.ferraro> updated the status of jira WFLY-1351 to Closed

Comment 3 JBoss JIRA Server 2013-07-25 18:57:22 UTC

Paul Ferraro <paul.ferraro> made a comment on jira WFLY-1351

CoreGroupCommunicationService is obsolete.  This issue does not apply to its replacement, CommandDispatcher.

Comment 5 Paul Ferraro 2013-08-29 19:25:55 UTC

Technically, this issue is still relevant to 6.2 and 6.3, as this class will continue to exist.  However, the plan for EAP 6.3 is to drop usage of this object for locking web sessions.

Comment 6 Paul Ferraro 2013-12-12 15:38:16 UTC

Rather than change the API (which would be necessary to return the appropriate exception back to the caller), we'll handle the null response in the distributed lock manager.

Comment 7 Paul Ferraro 2014-01-03 22:02:32 UTC

https://github.com/jbossas/jboss-eap/pull/750

Comment 8 Richard Janík 2014-02-18 13:55:37 UTC

6.3.0.DR0 verified.

Comment 11 sgilda 2014-05-12 18:18:36 UTC

Changed <literal></literal> tags in Doc Text to ticks (`) to fix Bug 1096865

Comment 12 sgilda 2014-05-12 18:28:00 UTC

Changed <literal></literal> tags in Doc Text to ticks (`) to fix Bug 1096865