Bug 963540

Summary:	[FEATURE] Enhance logging in protocol server
Product:	[Community] GlusterFS	Reporter:	Raghavendra G <rgowdapp>
Component:	protocol	Assignee:	Raghavendra G <rgowdapp>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:48:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra G 2013-05-16 06:22:55 UTC

Description of problem:
Currently we log the tuple (server-xlator-name, callid) for identifying
a call in log messages. However it does not uniquely identify the operation when there
are multiple clients (since operations from all clients go through same
server). Adding connection-id resolves this ambiguity.
Also printing connection-id helps diagnoise failures associated with
connection state (like fds, locks).

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2013-05-16 06:24:48 UTC

REVIEW: http://review.gluster.org/5011 (protocol/server: print connection-id in fop failure logs.) posted (#3) for review on master by Raghavendra G (raghavendra)

Comment 2 Anand Avati 2013-06-05 02:01:52 UTC

REVIEW: http://review.gluster.org/5011 (protocol/server: print connection-id in fop failure logs.) posted (#4) for review on master by Raghavendra G (raghavendra)

Comment 3 Anand Avati 2013-06-05 03:50:11 UTC

REVIEW: http://review.gluster.org/5147 (just a test Signed-off-by: jian.hou <hjimmy19870806>) posted (#1) for review on release-3.4 by 健 侯 (hjimmy19870806)

Comment 4 Anand Avati 2013-06-05 03:51:08 UTC

REVIEW: http://review.gluster.org/5147 (just a test) posted (#2) for review on release-3.4 by 健 侯 (hjimmy19870806)

Comment 5 Anand Avati 2013-06-19 06:27:54 UTC

COMMIT: http://review.gluster.org/5011 committed in master by Vijay Bellur (vbellur) 
------
commit 1d6f6a65d76f0e8dc9b62fdae305b6246ce268c5
Author: Raghavendra G <raghavendra>
Date:   Wed May 15 15:54:29 2013 +0530

    protocol/server: print connection-id in fop failure logs.
    
    Currently we have tuple (server-xlator-name, callid) for identifying
    a call. However it does not uniquely identify the operation when there
    are multiple clients (since operations from all clients go through same
    server). Adding connection-id resolves this ambiguity.
    Also printing connection-id helps diagnose failures associated with
    connection state (like fds, locks).
    
    Change-Id: I13563bd06ee9b72fc1a10d239f77db5183658573
    BUG: 963540
    Signed-off-by: Raghavendra G <raghavendra>
    Reviewed-on: http://review.gluster.org/5011
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>