Bug 963734

Summary: GET multiMetricData does not check for negative dataPoints value
Product: [Other] RHQ Project Reporter: Libor Zoubek <lzoubek>
Component: RESTAssignee: Heiko W. Rupp <hrupp>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.8CC: theute
Target Milestone: ---   
Target Release: RHQ 4.8   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-11 09:53:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 835647    
Bug Blocks:    
Attachments:
Description Flags
patch none

Description Libor Zoubek 2013-05-16 13:35:34 UTC 
Version-Release number of selected component (if applicable):
RHQ-4.8 master

How reproducible: always


Steps to Reproduce:
1. have a shedule with some metric data
2. do GET /metric/data/?sid=<schedule id>&dataPoints=0

  
Actual results: you get a lot of dataPoints (default value)


Expected results: server should return 406 response code 


Additional info: server returns 406 when you do GET /metric/data/<scheduleId>?dataPoints=0 so we should be consistent
Comment 1 Libor Zoubek 2013-05-29 19:15:00 UTC 
Created attachment 754518 [details]
patch
Comment 2 Heiko W. Rupp 2013-06-05 15:24:45 UTC 
addressed in master f14fbc3a29e by removing that query parameter, as internally we can use 60 buckets only at the moment.
Comment 3 Heiko W. Rupp 2013-06-06 11:11:40 UTC 
master bfa32dc

We now allow to supply variable number of data points with 60 being the default in various places. This above check has been implemented.
Comment 4 Heiko W. Rupp 2013-09-11 09:53:28 UTC 
Bulk closing of old issues now that HRQ 4.9 is in front of the door.

If you think the issue has not been solved, then please open a new bug and mention this one in the description.