Bug 963734 - GET multiMetricData does not check for negative dataPoints value
Summary: GET multiMetricData does not check for negative dataPoints value
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: REST
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHQ 4.8
Assignee: Heiko W. Rupp
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On: 835647
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-16 13:35 UTC by Libor Zoubek
Modified: 2015-11-02 00:43 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-11 09:53:28 UTC
Embargoed:

Attachments (Terms of Use)
patch (1.16 KB, patch)
2013-05-29 19:15 UTC, Libor Zoubek 		no flags Details | Diff
View All

Description Libor Zoubek 2013-05-16 13:35:34 UTC 
Version-Release number of selected component (if applicable):
RHQ-4.8 master

How reproducible: always


Steps to Reproduce:
1. have a shedule with some metric data
2. do GET /metric/data/?sid=<schedule id>&dataPoints=0

  
Actual results: you get a lot of dataPoints (default value)


Expected results: server should return 406 response code 


Additional info: server returns 406 when you do GET /metric/data/<scheduleId>?dataPoints=0 so we should be consistent
Comment 1 Libor Zoubek 2013-05-29 19:15:00 UTC 
Created attachment 754518 [details]
patch
Comment 2 Heiko W. Rupp 2013-06-05 15:24:45 UTC 
addressed in master f14fbc3a29e by removing that query parameter, as internally we can use 60 buckets only at the moment.
Comment 3 Heiko W. Rupp 2013-06-06 11:11:40 UTC 
master bfa32dc

We now allow to supply variable number of data points with 60 being the default in various places. This above check has been implemented.
Comment 4 Heiko W. Rupp 2013-09-11 09:53:28 UTC 
Bulk closing of old issues now that HRQ 4.9 is in front of the door.

If you think the issue has not been solved, then please open a new bug and mention this one in the description.
Note You need to log in before you can comment on or make changes to this bug.