Bug 965930

Summary: Review Request: spec-version-maven-plugin - Spec Version Maven Plugin
Product: [Fedora] Fedora Reporter: gil cattaneo <puntogil>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, tcallawa
Target Milestone: ---Flags: tcallawa: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: spec-version-maven-plugin-1.2-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-04 21:07:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 947509, 947511, 961168    

Description gil cattaneo 2013-05-22 04:49:51 UTC
Spec URL: http://gil.fedorapeople.org/spec-version-maven-plugin.spec
SRPM URL: http://gil.fedorapeople.org/spec-version-maven-plugin-1.2-1.fc18.src.rpm
Description: Maven Plugin to configure APIs version and
specs in a MANIFEST.Mf file.
Fedora Account System Username: gil

Comment 1 gil cattaneo 2013-05-22 04:59:56 UTC
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5408154

Comment 2 Tom "spot" Callaway 2013-05-26 02:07:45 UTC
Good:

- rpmlint checks return:

spec-version-maven-plugin.src: W: invalid-url Source0: spec-version-maven-plugin-1.2-src-svn.tar.gz

Safe to ignore (SVN source)

- package meets naming guidelines
- package meets packaging guidelines
- license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff okay, svn source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs okay
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 3 gil cattaneo 2013-05-26 02:45:08 UTC
Really thanks!

New Package SCM Request
=======================
Package Name: spec-version-maven-plugin
Short Description: Spec Version Maven Plugin
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-05-26 14:20:31 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-05-26 16:43:21 UTC
spec-version-maven-plugin-1.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/spec-version-maven-plugin-1.2-1.fc19

Comment 6 Fedora Update System 2013-05-26 17:04:29 UTC
spec-version-maven-plugin-1.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/spec-version-maven-plugin-1.2-1.fc18

Comment 7 Fedora Update System 2013-05-27 00:28:44 UTC
spec-version-maven-plugin-1.2-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-06-04 21:07:56 UTC
spec-version-maven-plugin-1.2-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 9 Fedora Update System 2013-06-05 03:18:01 UTC
spec-version-maven-plugin-1.2-1.fc19 has been pushed to the Fedora 19 stable repository.