Bug 966222
| Summary: | Review Request: nodejs-bignumber-js - Library for decimal and non-decimal arithmetic | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mmahut, notting, package-review, tdawson |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-bignumber-js-1.2.0-2.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-18 19:35:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 966223 | ||
|
Description
Troy Dawson
2013-05-22 19:55:56 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6019718 Troy, all looks good except for the name. The used convention looks to be "-js" instead of ".js" - can you please rename it? Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js.spec SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js-1.2.0-1.fc20.src.rpm - Updated to the latest release - I don't understand what you mean by the convention is -js instead of .js. The name of the package is bignumber.js, and all the packages and dependencies expect it to have that name. Or am I not understanding what you are saying. Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber-js.spec SRPM URL: http://tdawson.fedorapeople.org/nodejs/ nodejs-bignumber-js-1.2.0-2.fc20.src.rpm - Renamed to conform to Fedora naming guidelines -- https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators - Checked to make sure it still provides npm(bignumber.js) -- This maintains compatibility with other scripts that depend on it. Discussed the dot over IRC. Thank you Troy, looks good! New Package SCM Request ======================= Package Name: nodejs-bignumber-js Short Description: Library for decimal and non-decimal arithmetic Owners: tdawson Branches: f18 f19 f20 el6 InitialCC: Requested package name nodejs-bignumber-js doesn't match bug summary nodejs-bignumber.js, please correct. Summary updated to match final name of package New Package SCM Request ======================= Package Name: nodejs-bignumber-js Short Description: Library for decimal and non-decimal arithmetic Owners: tdawson Branches: f18 f19 f20 el6 InitialCC: Git done (by process-git-requests). nodejs-bignumber-js-1.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-bignumber-js-1.2.0-2.fc19 nodejs-bignumber-js-1.2.0-2.fc19 has been pushed to the Fedora 19 testing repository. nodejs-bignumber-js-1.2.0-2.fc19 has been pushed to the Fedora 19 stable repository. |