Bug 966222 - Review Request: nodejs-bignumber-js - Library for decimal and non-decimal arithmetic
Summary: Review Request: nodejs-bignumber-js - Library for decimal and non-decimal ari...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 966223
TreeView+ depends on / blocked
 
Reported: 2013-05-22 19:55 UTC by Troy Dawson
Modified: 2013-10-18 19:35 UTC (History)
4 users (show)

Fixed In Version: nodejs-bignumber-js-1.2.0-2.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-10-18 19:35:32 UTC
Type: ---
Embargoed:
mmahut: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Troy Dawson 2013-05-22 19:55:56 UTC
Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js.spec
SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js-1.0.1-1.fc20.src.rpm
Description: A library for arbitrary-precision decimal and non-decimal arithmetic.
Fedora Account System Username: tdawson

Comment 1 Marek Mahut 2013-10-03 13:55:35 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6019718

Troy, all looks good except for the name. The used convention looks to be "-js" instead of ".js" - can you please rename it?

Comment 2 Troy Dawson 2013-10-03 21:15:58 UTC
Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js.spec
SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js-1.2.0-1.fc20.src.rpm

- Updated to the latest release
- I don't understand what you mean by the convention is -js instead of .js.  The name of the package is bignumber.js, and all the packages and dependencies expect it to have that name.  Or am I not understanding what you are saying.

Comment 3 Troy Dawson 2013-10-07 14:31:33 UTC
Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber-js.spec
SRPM URL: http://tdawson.fedorapeople.org/nodejs/
nodejs-bignumber-js-1.2.0-2.fc20.src.rpm

- Renamed to conform to Fedora naming guidelines
-- https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
- Checked to make sure it still provides npm(bignumber.js)
-- This maintains compatibility with other scripts that depend on it.

Comment 4 Marek Mahut 2013-10-07 14:55:10 UTC
Discussed the dot over IRC.

Thank you Troy, looks good!

Comment 5 Troy Dawson 2013-10-07 15:25:25 UTC
New Package SCM Request
=======================
Package Name: nodejs-bignumber-js
Short Description: Library for decimal and non-decimal arithmetic
Owners: tdawson
Branches: f18 f19 f20 el6
InitialCC:

Comment 6 Gwyn Ciesla 2013-10-07 15:41:20 UTC
Requested package name nodejs-bignumber-js doesn't match bug summary
nodejs-bignumber.js, please correct.

Comment 7 Troy Dawson 2013-10-07 15:52:42 UTC
Summary updated to match final name of package

Comment 8 Troy Dawson 2013-10-07 15:53:22 UTC
New Package SCM Request
=======================
Package Name: nodejs-bignumber-js
Short Description: Library for decimal and non-decimal arithmetic
Owners: tdawson
Branches: f18 f19 f20 el6
InitialCC:

Comment 9 Gwyn Ciesla 2013-10-07 16:12:16 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2013-10-07 16:56:37 UTC
nodejs-bignumber-js-1.2.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-bignumber-js-1.2.0-2.fc19

Comment 11 Fedora Update System 2013-10-10 00:53:06 UTC
nodejs-bignumber-js-1.2.0-2.fc19 has been pushed to the Fedora 19 testing repository.

Comment 12 Fedora Update System 2013-10-18 19:35:32 UTC
nodejs-bignumber-js-1.2.0-2.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.