Bug 967333
| Summary: | Review Request: rubygem-code_analyzer - Helps build custom code analyzer tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedoraparked |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedoraparked, hhorak, package-review, vondruch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-04 08:55:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
fedoraparked
2013-05-26 17:23:46 UTC
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-code_analyzer/mock rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. I will take it for a review. * mark LICENSE as %doc * move README.md to the -doc sub-package - it's not needed at runtime * move Gemfile and Rakefile to -doc sub-package rather than excluding them * fix Summary "Helps build custom code analyzer tools" sounds a bit better to me. But please put the summary as a short description here in Bugzilla next time so it's the same as in spec. * fix Description (missing "which IS") - e.g.: The code analyzer tool which is extracted from rails_best_practices helps you easily build your own tool for code analysis. Otherwise, it builds and runs just fine. Please fix the spec file so I can approve. Updated: Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_analyzer.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_analyzer-0.3.1-2.fc19.src.rpm Looks good now. 2 minor things that would be nice to do:
* Description of -doc sub-package should end with a dot "." as a normal English sentence, please add it.
* Be more specific when listing files
%doc %{gem_instdir}/*.gemspec > %doc %{gem_instdir}/%{gem_name}.gemspec
Since those are not blockers I APPROVE this package. Please fix above mentioned issues before pushing.
Closing this stalled review. |