Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_analyzer.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_analyzer-0.3.1-1.fc19.src.rpm Description: Helps build custom code analyzer tools Fedora Account System Username: anujmore
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-code_analyzer/mock rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
I will take it for a review.
* mark LICENSE as %doc * move README.md to the -doc sub-package - it's not needed at runtime * move Gemfile and Rakefile to -doc sub-package rather than excluding them * fix Summary "Helps build custom code analyzer tools" sounds a bit better to me. But please put the summary as a short description here in Bugzilla next time so it's the same as in spec. * fix Description (missing "which IS") - e.g.: The code analyzer tool which is extracted from rails_best_practices helps you easily build your own tool for code analysis. Otherwise, it builds and runs just fine. Please fix the spec file so I can approve.
Updated: Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_analyzer.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-code_analyzer/rubygem-code_analyzer-0.3.1-2.fc19.src.rpm
Looks good now. 2 minor things that would be nice to do: * Description of -doc sub-package should end with a dot "." as a normal English sentence, please add it. * Be more specific when listing files %doc %{gem_instdir}/*.gemspec > %doc %{gem_instdir}/%{gem_name}.gemspec Since those are not blockers I APPROVE this package. Please fix above mentioned issues before pushing.
Closing this stalled review.